Replace Travis with Github Actions for CI builds

CHANGELOG.md

@@ -1,7 +1,9 @@
 # Unreleased
   - Changes from 5.25.0
     - API:
-      - FIXED: Allow for special characters in the profile/method as part of the HTTP URL.
+      - FIXED: Allow for special characters in the profile/method as part of the HTTP URL. [#6090](https://github.com/Project-OSRM/osrm-backend/pull/6090)
+    - Build:
+      - CHANGED: Replace Travis with Github Actions for CI builds [#6071](https://github.com/Project-OSRM/osrm-backend/pull/6071)
 
 # 5.25.0
   - Changes from 5.24.0

CMakeLists.txt

@@ -514,7 +514,7 @@ if(ENABLE_MASON)
   set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} ${LINKER_FLAGS}")
 
   # current mason packages target -D_GLIBCXX_USE_CXX11_ABI=0
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -D_GLIBCXX_USE_CXX11_ABI=0")
+  add_dependency_defines(-D_GLIBCXX_USE_CXX11_ABI=0)
 
   # note: we avoid calling find_package(Osmium ...) here to ensure that the
   # expat and bzip2 are used from mason rather than the system
@@ -862,4 +862,4 @@ if (ENABLE_NODE_BINDINGS)
   endforeach()
   add_library(check-headers STATIC EXCLUDE_FROM_ALL ${sources})
   set_target_properties(check-headers PROPERTIES ARCHIVE_OUTPUT_DIRECTORY ${check_headers_dir})
-endif()
+endif()

src/extractor/maneuver_override_relation_parser.cpp

@@ -1,14 +1,8 @@
 #include "extractor/maneuver_override_relation_parser.hpp"
 #include "extractor/maneuver_override.hpp"
 
-#include "util/log.hpp"
-
-#include <boost/algorithm/string.hpp>
-#include <boost/algorithm/string/predicate.hpp>
-#include <boost/algorithm/string/regex.hpp>
 #include <boost/optional/optional.hpp>
 #include <boost/ref.hpp>
-#include <boost/regex.hpp>
 
 #include <osmium/osm.hpp>
 #include <osmium/tags/filter.hpp>

src/extractor/restriction_parser.cpp

@@ -5,10 +5,8 @@
 #include "util/log.hpp"
 
 #include <boost/algorithm/string/predicate.hpp>
-#include <boost/algorithm/string/regex.hpp>
 #include <boost/optional/optional.hpp>
 #include <boost/ref.hpp>
-#include <boost/regex.hpp>
 
 #include <osmium/osm.hpp>
 #include <osmium/tags/regex_filter.hpp>
@@ -244,14 +242,15 @@ bool RestrictionParser::ShouldIgnoreRestriction(const std::string &except_tag_st
 
     // Be warned, this is quadratic work here, but we assume that
     // only a few exceptions are actually defined.
-    std::vector<std::string> exceptions;
-    boost::algorithm::split_regex(exceptions, except_tag_string, boost::regex("[;][ ]*"));
+    const std::regex delimiter_re("[;][ ]*");
+    std::sregex_token_iterator except_tags_begin(
+        except_tag_string.begin(), except_tag_string.end(), delimiter_re, -1);
+    std::sregex_token_iterator except_tags_end;
 
-    return std::any_of(
-        std::begin(exceptions), std::end(exceptions), [&](const std::string &current_string) {
-            return std::end(restrictions) !=
-                   std::find(std::begin(restrictions), std::end(restrictions), current_string);
-        });
+    return std::any_of(except_tags_begin, except_tags_end, [&](const std::string &current_string) {
+        return std::end(restrictions) !=
+               std::find(std::begin(restrictions), std::end(restrictions), current_string);
+    });
 }
 } // namespace extractor
 } // namespace osrm

unit_tests/library/json.cpp

@@ -6,7 +6,6 @@
 #include "engine/api/json_factory.hpp"
 #include "osrm/coordinate.hpp"
 
-#include <iterator>
 #include <vector>
 
 using namespace osrm;
@@ -27,7 +26,7 @@ BOOST_AUTO_TEST_CASE(test_json_linestring)
     const auto coords = geom.values["coordinates"].get<util::json::Array>().values;
     BOOST_CHECK_EQUAL(coords.size(), 3); // array of three location arrays
 
-    for (const auto each : coords)
+    for (const auto &each : coords)
     {
         const auto loc = each.get<util::json::Array>().values;
         BOOST_CHECK_EQUAL(loc.size(), 2);
@@ -53,7 +52,7 @@ BOOST_AUTO_TEST_CASE(test_json_single_point)
     const auto coords = geom.values["coordinates"].get<util::json::Array>().values;
     BOOST_CHECK_EQUAL(coords.size(), 2); // array of two location arrays
 
-    for (const auto each : coords)
+    for (const auto &each : coords)
     {
         const auto loc = each.get<util::json::Array>().values;
         BOOST_CHECK_EQUAL(loc.size(), 2);

unit_tests/library/match.cpp

@@ -184,7 +184,7 @@ BOOST_AUTO_TEST_CASE(test_match_fb_serialization)
     const auto matchings = fb->routes();
     const auto &number_of_matchings = matchings->size();
 
-    for (const auto &waypoint : *waypoints)
+    for (const auto waypoint : *waypoints)
     {
         BOOST_CHECK(waypoint_check(waypoint));
         const auto matchings_index = waypoint->matchings_index();

unit_tests/library/nearest.cpp

@@ -202,7 +202,7 @@ BOOST_AUTO_TEST_CASE(test_nearest_fb_serialization)
     auto waypoints = fb->waypoints();
     BOOST_CHECK(waypoints->size() > 0); // the dataset has at least one nearest coordinate
 
-    for (const auto &waypoint : *waypoints)
+    for (const auto waypoint : *waypoints)
     {
         BOOST_CHECK(waypoint->distance() >= 0);
         BOOST_CHECK(waypoint->nodes()->first() != 0);

unit_tests/library/route.cpp

@@ -263,7 +263,7 @@ void test_route_same_coordinates(bool use_json_only_api)
                     const auto &entries = intersection_object.at("entry").get<json::Array>().values;
                     BOOST_CHECK(bearings.size() == entries.size());
 
-                    for (const auto bearing : bearings)
+                    for (const auto &bearing : bearings)
                         BOOST_CHECK(0. <= bearing.get<json::Number>().value &&
                                     bearing.get<json::Number>().value <= 360.);
 
@@ -619,7 +619,7 @@ BOOST_AUTO_TEST_CASE(test_route_serialize_fb)
     const auto waypoints = fb->waypoints();
     BOOST_CHECK(waypoints->size() == params.coordinates.size());
 
-    for (const auto &waypoint : *waypoints)
+    for (const auto waypoint : *waypoints)
     {
         const auto longitude = waypoint->location()->longitude();
         const auto latitude = waypoint->location()->latitude();
@@ -633,15 +633,15 @@ BOOST_AUTO_TEST_CASE(test_route_serialize_fb)
     const auto routes = fb->routes();
     BOOST_REQUIRE_GT(routes->size(), 0);
 
-    for (const auto &route : *routes)
+    for (const auto route : *routes)
     {
         BOOST_CHECK_EQUAL(route->distance(), 0);
         BOOST_CHECK_EQUAL(route->duration(), 0);
 
         const auto &legs = route->legs();
         BOOST_CHECK(legs->size() > 0);
 
-        for (const auto &leg : *legs)
+        for (const auto leg : *legs)
         {
             BOOST_CHECK_EQUAL(leg->distance(), 0);
 
@@ -720,7 +720,7 @@ BOOST_AUTO_TEST_CASE(test_route_serialize_fb_skip_waypoints)
     const auto routes = fb->routes();
     BOOST_REQUIRE_GT(routes->size(), 0);
 
-    for (const auto &route : *routes)
+    for (const auto route : *routes)
     {
         BOOST_CHECK_EQUAL(route->distance(), 0);
         BOOST_CHECK_EQUAL(route->duration(), 0);

unit_tests/library/table.cpp

@@ -332,14 +332,14 @@ BOOST_AUTO_TEST_CASE(test_table_serialiaze_fb)
     // check destinations array of waypoint objects
     const auto &destinations_array = fb->table()->destinations();
     BOOST_CHECK_EQUAL(destinations_array->size(), params.destinations.size());
-    for (const auto &destination : *destinations_array)
+    for (const auto destination : *destinations_array)
     {
         BOOST_CHECK(waypoint_check(destination));
     }
     // check sources array of waypoint objects
     const auto &sources_array = fb->waypoints();
     BOOST_CHECK_EQUAL(sources_array->size(), params.sources.size());
-    for (const auto &source : *sources_array)
+    for (const auto source : *sources_array)
     {
         BOOST_CHECK(waypoint_check(source));
     }

unit_tests/library/trip.cpp

@@ -525,7 +525,7 @@ BOOST_AUTO_TEST_CASE(test_roundtrip_response_fb_serialization)
     const auto trips = fb->routes();
     BOOST_CHECK_EQUAL(trips->size(), 1);
 
-    for (const auto &waypoint : *waypoints)
+    for (const auto waypoint : *waypoints)
     {
         const auto longitude = waypoint->location()->longitude();
         const auto latitude = waypoint->location()->latitude();

unit_tests/server/url_parser.cpp

@@ -126,8 +126,10 @@ BOOST_AUTO_TEST_CASE(valid_urls)
     BOOST_CHECK_EQUAL(reference_8.prefix_length, result_8->prefix_length);
 
     // profile with special characters
-    api::ParsedURL reference_9{"route", 1, "foo-bar_baz.profile", "0,1;2,3;4,5?options=value&foo=bar", 30UL};
-    auto result_9 = api::parseURL("/route/v1/foo-bar_baz.profile/0,1;2,3;4,5?options=value&foo=bar");
+    api::ParsedURL reference_9{
+        "route", 1, "foo-bar_baz.profile", "0,1;2,3;4,5?options=value&foo=bar", 30UL};
+    auto result_9 =
+        api::parseURL("/route/v1/foo-bar_baz.profile/0,1;2,3;4,5?options=value&foo=bar");
     BOOST_CHECK(result_9);
     BOOST_CHECK_EQUAL(reference_9.service, result_9->service);
     BOOST_CHECK_EQUAL(reference_9.version, result_9->version);