Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Boost.Regex from the list of dependencies #6278

Conversation

SiarheiFedartsou
Copy link
Member

Issue

Noticed that we do not use it.

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@SiarheiFedartsou SiarheiFedartsou marked this pull request as ready for review July 9, 2022 18:38
@mjjbell
Copy link
Member

mjjbell commented Jul 9, 2022

I've also tried this in the past.

The Windows build gets confused if the Boost regex library is in the dependency directory but is not included in the build.
It needs to be removed from the zip file containing the dependencies, but it's hosted in a Wolt S3 bucket. I'm not sure who has access.

I think it's probably better to put effort into tackling #6266, and including the Windows build in any solution.

@SiarheiFedartsou
Copy link
Member Author

I've also tried this in the past.

The Windows build gets confused if the Boost regex library is in the dependency directory but is not included in the build. It needs to be removed from the zip file containing the dependencies, but it's hosted in a Wolt S3 bucket. I'm not sure who has access.

I think it's probably better to put effort into tackling #6266, and including the Windows build in any solution.

Okay, I've been already experimenting with Conan. 👍

@SiarheiFedartsou
Copy link
Member Author

I've also tried this in the past.
The Windows build gets confused if the Boost regex library is in the dependency directory but is not included in the build. It needs to be removed from the zip file containing the dependencies, but it's hosted in a Wolt S3 bucket. I'm not sure who has access.
I think it's probably better to put effort into tackling #6266, and including the Windows build in any solution.

Okay, I've been already experimenting with Conan. 👍

As promised :) #6284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants