Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: trim-error #27

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

RanDXDev
Copy link
Contributor

@RanDXDev RanDXDev commented Aug 17, 2023

Overview

Fix trim issue when having 0 properties and pressing on the add property button

Details

Fixing trim issue on ps realtor, sometimes the string is undefined, but if you force to call trim function it will throw error and messed up the UI, so adding a optional chaining operator (?) prevent it to throw error

UI Changes / Functionality

Before fix:
https://streamable.com/30jzx3

After fix:
https://streamable.com/1q55yv

Testing Steps

Provide a list of repro steps on how to test that your changes are valid.

  • [✅] Did you test the changes you made?
  • [✅ ] Did you test core functionality of the script to ensure your changes do not regress other areas?
  • [❌] Did you test your changes in multiplayer to ensure it works correctly on all clients? (Don't have friend and my pc too potato😔)

@LeSiiN
Copy link
Contributor

LeSiiN commented Aug 17, 2023

Tested myself, working so far

@Martinator9001
Copy link
Contributor

Worked for me as well.

@Martinator9001
Copy link
Contributor

Martinator9001 commented Aug 28, 2023

Also tried it out with my server's realtor a while ago, so you can mark off the 3rd one if you think that's enough

@Martinator9001
Copy link
Contributor

@MonkeyWhisper
Copy link
Member

Tested myself on a fresh copy was able to duplicate the issue and this fixed it

@MonkeyWhisper MonkeyWhisper merged commit 4501f45 into Project-Sloth:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants