-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix debug images for shells #43
Conversation
@rxnm, please also add the src file with the updated links. Otherwise, all the links will revert to the old ones, when this is recompiled locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment.
Hey mate, not quite sure how to do this, mind explaining more? thanks. |
@rxnm You can check if your git is ignoring it, If it is, then you need to remove it then you can push the source files, and by source files, it's the svelte files you edited, If you only changed the links in the compiled files, you would need to change it in svelte then recompile and push. |
Added (AlwaysListener.svelte) images now.
Should be fine now, sorry for the mistake, quite new to svelte. |
Alright, so after checking, The links in the realtor side of things and AlwaysListener links are just for Debugging, but it pulls the info from Housing, Which on that side has always been updated but isn't using the same CDN, other than that. Everything is good now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Overview
Provide a brief overview of the purpose of this pull request
Details
Provide details on the change you are making, why they are necessary, and any information that will help with understanding.
UI Changes / Functionality
Include a before and after screenshot/recording if applicable. Short recordings showing that your changes work are helpful, but optional.
Testing Steps
Provide a list of repro steps on how to test that your changes are valid.