Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug images for shells #43

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Fix debug images for shells #43

merged 2 commits into from
Jul 10, 2024

Conversation

rxnm
Copy link
Contributor

@rxnm rxnm commented Jul 9, 2024

Overview

Provide a brief overview of the purpose of this pull request

Details

Provide details on the change you are making, why they are necessary, and any information that will help with understanding.

UI Changes / Functionality

Include a before and after screenshot/recording if applicable. Short recordings showing that your changes work are helpful, but optional.

Testing Steps

Provide a list of repro steps on how to test that your changes are valid.

  • Did you test the changes you made?
  • Did you test core functionality of the script to ensure your changes do not regress other areas?
  • Did you test your changes in multiplayer to ensure it works correctly on all clients?

@rxnm rxnm mentioned this pull request Jul 9, 2024
@xFutte
Copy link
Member

xFutte commented Jul 9, 2024

@rxnm, please also add the src file with the updated links. Otherwise, all the links will revert to the old ones, when this is recompiled locally.

@xFutte xFutte assigned xFutte and unassigned xFutte Jul 9, 2024
@xFutte xFutte self-requested a review July 9, 2024 22:04
Copy link
Member

@xFutte xFutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

@rxnm
Copy link
Contributor Author

rxnm commented Jul 10, 2024

@rxnm, please also add the src file with the updated links. Otherwise, all the links will revert to the old ones, when this is recompiled locally.

Hey mate, not quite sure how to do this, mind explaining more? thanks.

@complexza
Copy link
Member

complexza commented Jul 10, 2024

@rxnm You can check if your git is ignoring it, If it is, then you need to remove it then you can push the source files, and by source files, it's the svelte files you edited, If you only changed the links in the compiled files, you would need to change it in svelte then recompile and push.

Added (AlwaysListener.svelte) images now.
@rxnm
Copy link
Contributor Author

rxnm commented Jul 10, 2024

Should be fine now, sorry for the mistake, quite new to svelte.

@complexza
Copy link
Member

Should be fine now, sorry for the mistake, quite new to svelte.

Alright, so after checking, The links in the realtor side of things and AlwaysListener links are just for Debugging, but it pulls the info from Housing, Which on that side has always been updated but isn't using the same CDN, other than that.

Everything is good now!

Copy link
Member

@xFutte xFutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xFutte xFutte changed the title Update image links to index.js Fix debug images for shells Jul 10, 2024
@xFutte xFutte merged commit e2cabb5 into Project-Sloth:main Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants