exclude JSON script tags from JS bundling (#1231)

ProjectEvergreen · May 23, 2024 · 28eedde · 28eedde
1 parent d0a01a7
commit 28eedde
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/packages/cli/src/lib/resource-utils.js b/packages/cli/src/lib/resource-utils.js
@@ -124,7 +124,8 @@ async function trackResourcesForRoute(html, compilation, route) {
   const scripts = await Promise.all(root.querySelectorAll('script')
     .filter(script => (
       isLocalLink(script.getAttribute('src')) || script.rawText)
-      && script.rawAttrs.indexOf('importmap') < 0)
+      && script.rawAttrs.indexOf('importmap') < 0
+      && script.getAttribute('type') !== 'application/json')
     .map(async(script) => {
       const src = script.getAttribute('src');
       const optimizationAttr = script.getAttribute('data-gwd-opt');

diff --git a/...ses/build.default.workspace-javascript-css/build.default.workspace-javascript-css.spec.js b/...ses/build.default.workspace-javascript-css/build.default.workspace-javascript-css.spec.js
@@ -78,7 +78,7 @@ describe('Build Greenwood With: ', function() {
       it('should have two <script> tag with inline script in the <head>', function() {
         const scriptTagInline = Array.from(dom.window.document.querySelectorAll('head > script:not([src])')).filter(tag => !tag.getAttribute('data-gwd'));
 
-        expect(scriptTagInline.length).to.be.equal(4);
+        expect(scriptTagInline.length).to.be.equal(5);
       });
 
       it('should have the expected inline content from inline <script> tag one in index.html', async function() {
@@ -99,6 +99,13 @@ describe('Build Greenwood With: ', function() {
         expect(scriptTagSrcTwo.textContent).to.contain('document.getElementsByClassName("output-script-inline-three")[0].innerHTML="script tag module inline three"');
       });
 
+      it('should have the expected <script> tag of type application/json', async function() {
+        const scriptJson = Array.from(dom.window.document.querySelectorAll('head > script[type="application/json"]'));
+
+        expect(scriptJson.length).to.equal(1);
+        expect(JSON.parse(scriptJson[0].textContent).message).to.equal('calmer than you are');
+      });
+
     });
 
     describe('non module <script src="..."></script> tag in the <head>', function() {

diff --git a/packages/cli/test/cases/build.default.workspace-javascript-css/src/pages/index.html b/packages/cli/test/cases/build.default.workspace-javascript-css/src/pages/index.html
@@ -47,6 +47,10 @@
     </script>
 
     <script src="/scripts/non-module.js"></script>
+
+    <script type="application/json">
+      {"message": "calmer than you are" }
+     </script>
   </head>
 
   <body>