-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore Init package --install
based test cases
#787
Comments
--install
based test cases
Maybe this could get solved by using |
From https://github.com/ProjectEvergreen/greenwood/pull/992/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R25, we will want to figure out how to enable the init test cases on Windows, but wasn't getting a lot of debug info out of it, so just deferred to this ticket instead. |
So reviewing this again, it seems like the issue is just down the Yarn specs, but there is a new (thankfully very relevant!) error, related to a deprecation in rollup-plugin-terser now. 1) Scaffold Greenwood With Yarn:
default minimal template
"before all" hook in "default minimal template":
Error: the string "warning @greenwood/cli > rollup-plugin-terser@7.0.2: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-terser\n" was thrown, throw an Error :) And so in fact, that plugin is indeed deprecated, and has moved to @rollup organization So I'm thinking if we can clear that up, maybe I can take another run at this, but will need the package upgrade to flow through mainline Greenwood first into the template repo. 🤞 |
Type of Change
Summary
As part of #777 to introduce the new Init package, one issue that came up was that when running
yarn install
as part of the test suite, warnings were getting thrown as errors.This would cause the test to fail, though there was nothing really wrong at all.
While using
ignore
for the stdio does help pass the testThe result would be that users would not get any install logs at all when running
@greenwood/init
during theinstall
step which is confusing and potentially disruptive, making the user think something has broken and potentially cancelling out the whole operation.Details
Would like to restore this test case while still keeping the
stdio
setting such that theinstall
logs still show. Not sure if this is something to fix in gallinago or something we can work around in our test setup or not, so making this issue to track and try and resolve.Here is the PR that reverted the
stdio
setting and had the relevant specs set toxdescribe
. What is interesting is that Windows action passed, but the Linux one failed even for npm. Probably more to do with how process spawning is handled between the too.The text was updated successfully, but these errors were encountered: