Feature/issue 878 ssr custom resources #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
documentation
thescientist13
force-pushed
the
feature/issue-878-ssr-custom-resources
branch
from
a640af1
to
8764136
Compare
thescientist13
force-pushed
the
release/0.27.0
branch
from
c3a5029
to
00e2df7
Compare
thescientist13
force-pushed
the
feature/issue-878-ssr-custom-resources
branch
from
d75dfab
to
04cca5a
Compare
thescientist13
commented
Nov 11, 2022
.nvmrc
Outdated
| @@ -1 +1 @@ | |||
| 14.17.0 | |||
| 16.15.0 | |||
There was a problem hiding this comment.
maybe this should actually be 16.17.0 to align with loaders API
thescientist13
force-pushed
the
release/0.27.0
branch
from
6cfba1d
to
c781ddb
Compare
* add cloud IDE caveat to puppeteer renderer plugin readme (#967) * init commit of refactoring for script tags with a src * initial CSS optimizing * sync optimized link tags in final output * refactored for shared reources * handle inline script bundling * support serving custom resources using Greenwood plugins in Rollup configuration without needing extra rollup plugin * non resource related Rollup plugins supported * custom resource plugins and rollup plugins working together * handle empty input for Rollup * updated lock file * handle inline style tag bundling and optimizing * default optimization spec passing * refactor merging app and page templates * clarifying corrections in spec files * inline optimization config working * none optimization support * none optimization support * none and static optimization overrides * refactor html rendering and optimizing * refactoring and more CLI specs passing * add missing variable * SSR specs and optimizing resource bundling * minor refactoring and logging * resolving some plugin specs * restore develop command related GraphQL specs * custom graphql query spec * all specs passing * drop rollup plugin deps from import typescript plugin * all Greenwood commands and specs passing * restore static router with custom prerender * restore postcss-import * refactor shared resources to a Map and handle dupes * restore local packages workaround for local Rollup bundling * better monorepo Rollup facade modules detection * switch console log * remove console logging * update plugin related docs * local solution for windows support * refactor errant object assign * full cross platform URL support * fix lint * fix extra bundles when custom prerendering * clean up stale or already tracked TODOs * add nested head tag smoke tests * check for app template validation for HUD display * misc refactoring and TODOs cleanup * restore static router (again) * standardize passing correct reference for prerender scripts * clean up data-gwd-opt markers from final HTML
thescientist13
force-pushed
the
feature/issue-878-ssr-custom-resources
branch
from
d6bdb32
to
4a448cf
Compare
thescientist13
commented
Nov 21, 2022
| @@ -203,6 +203,26 @@ async function getTemplate(compilation, route) { | |||
| } | |||
| ``` | |||
|
|
|||
| ### Custom Imports (Experimental) | |||
There was a problem hiding this comment.
Should move the Experimental to its own line so deep links don't break when / if the experimental label gets removed.
5 tasks
7 tasks
thescientist13
added a commit
that referenced
this pull request
Nov 23, 2022
* Enhancement/issue 971 refactor bundling and optimizations (#974) * add cloud IDE caveat to puppeteer renderer plugin readme (#967) * init commit of refactoring for script tags with a src * initial CSS optimizing * sync optimized link tags in final output * refactored for shared reources * handle inline script bundling * support serving custom resources using Greenwood plugins in Rollup configuration without needing extra rollup plugin * non resource related Rollup plugins supported * custom resource plugins and rollup plugins working together * handle empty input for Rollup * updated lock file * handle inline style tag bundling and optimizing * default optimization spec passing * refactor merging app and page templates * clarifying corrections in spec files * inline optimization config working * none optimization support * none optimization support * none and static optimization overrides * refactor html rendering and optimizing * refactoring and more CLI specs passing * add missing variable * SSR specs and optimizing resource bundling * minor refactoring and logging * resolving some plugin specs * restore develop command related GraphQL specs * custom graphql query spec * all specs passing * drop rollup plugin deps from import typescript plugin * all Greenwood commands and specs passing * restore static router with custom prerender * restore postcss-import * refactor shared resources to a Map and handle dupes * restore local packages workaround for local Rollup bundling * better monorepo Rollup facade modules detection * switch console log * remove console logging * update plugin related docs * local solution for windows support * refactor errant object assign * full cross platform URL support * fix lint * fix extra bundles when custom prerendering * clean up stale or already tracked TODOs * add nested head tag smoke tests * check for app template validation for HUD display * misc refactoring and TODOs cleanup * restore static router (again) * standardize passing correct reference for prerender scripts * clean up data-gwd-opt markers from final HTML * v0.27.0-alpha.0 * experimental loaders for SSR custom resources * set minimum nodejs v16.x requirement * latest WIP * custom SSR loaders for JSON * working test case testing for SSR prerender with import CSS plugin * experimental test task and github actions * remove demo code * add test cases for import JSON with prerendering * upgrade latest gallinago * enable experimental testing capabilities for CI * post rebase reconsilations * align versioning * experimental specs passing on windows * remove lint from experimental github actions * refine exp test tasks * minor refactor * fix windows exp github action workflow * increase mocha timeout for to accomodate exp test runs * formatting * updated import CSS and JSON plugin README docs * SSR usage for experimental loaders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolves #878 (alternative to #930)
Summary of Changes
importwith CSS and JSON in NodeJSTODO
CSSJSONenable in GitHub Actions$(pwd)in Windows)~~--installbased test cases #787 (comment)staticRouter- breaks onwindowgreenwoodPluginPolyfills- breaks onwindowwindow/globalThishandling wcc#100prerendervs SSR vs CSR) #951?type=jsonis still useful / needed - breaks in SSR, so should try and cutover to import assertions - import attributes for standard module formats; CSS and JSON #923shortCircuitto validate correct settings / usage16.x(and18.x?) for project + GitHub Actions - standalone PRbuildanddevelopcommands