Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

puppeteer based renderer plugin and HTMLElement (WCC) as default renderer #954

Closed
1 of 9 tasks
Tracked by #956
thescientist13 opened this issue Jul 1, 2022 · 0 comments · Fixed by #960 or #956
Closed
1 of 9 tasks
Tracked by #956

puppeteer based renderer plugin and HTMLElement (WCC) as default renderer #954

thescientist13 opened this issue Jul 1, 2022 · 0 comments · Fixed by #960 or #956
Assignees
@thescientist13
Labels
alpha.1 breaking CLI documentation Greenwood specific docs feature New feature or request Plugins Greenwood Plugins SSR v0.26.0
Milestone
1.0

Comments

@thescientist13
Copy link
Member

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

With the introduction of #943 for SSR, we don't need to have puppeteer as a default package or renderer. Instead it could be moved to its own renderer.

Details

With this breaking change, it will be done as part of the next release; v0.26.0. We will want to make sure:

  1. Clean up optional install introduced by auto-detect and install puppeteer dependency for default prerendering #916
  2. Move dependencies out of the CLI package.json
  3. Update relevant website documentation
  4. Make WCC / HTMLElement default renderer and prerender implementation
@thescientist13 thescientist13 added documentation Greenwood specific docs Plugins Greenwood Plugins CLI breaking SSR feature New feature or request labels Jul 1, 2022
@thescientist13 thescientist13 added this to the 1.0 milestone Jul 1, 2022
@thescientist13 thescientist13 self-assigned this Jul 1, 2022
This was referenced Jul 1, 2022
Merged
Merged
Merged
Merged
@thescientist13 thescientist13 mentioned this issue Jul 10, 2022
Merged
7 tasks
@thescientist13 thescientist13 changed the title puppeteer based renderer plugin and HTMLElement as default renderer puppeteer based renderer plugin and HTMLElement (WCC) as default renderer Jul 11, 2022
@thescientist13 thescientist13 linked a pull request Jul 11, 2022 that will close this issue
Feature/issue 954 puppeteer plugin #960
Merged
7 tasks
@thescientist13 thescientist13 linked a pull request Jul 27, 2022 that will close this issue
release/0.26.0 #956
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
alpha.1 breaking CLI documentation Greenwood specific docs feature New feature or request Plugins Greenwood Plugins SSR v0.26.0
Projects
None yet
Milestone
1.0
1 participant
@thescientist13