-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 935 native custom element ssr #943
Merged
thescientist13
merged 15 commits into
release/0.26.0
from
feature/issue-935-native-custom-element-ssr
Jul 1, 2022
Merged
Feature/issue 935 native custom element ssr #943
thescientist13
merged 15 commits into
release/0.26.0
from
feature/issue-935-native-custom-element-ssr
Jul 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
documentation
Greenwood specific docs
CLI
feature
New feature or request
labels
Jun 5, 2022
thescientist13
force-pushed
the
feature/issue-935-native-custom-element-ssr
branch
from
June 18, 2022 15:16
e7e975e
to
8e4c1d9
Compare
thescientist13
commented
Jun 19, 2022
data.frontmatter = data.frontmatter || {}; | ||
data.frontmatter.imports = data.frontmatter.imports || []; | ||
|
||
for (const entry in metadata) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should probably make this conditional and opt-out by default, as part of #880
…favor of puppeteer
automatically
thescientist13
force-pushed
the
feature/issue-935-native-custom-element-ssr
branch
from
July 1, 2022 00:12
ea78b2d
to
cdc7745
Compare
9 tasks
thescientist13
added a commit
that referenced
this pull request
Jul 27, 2022
* initial working local development example with wc-compiler for SSR native HTMLElement * restore getTemplate to original location in SSR route worker * bump latest version of wcc * ensure passing of URLs to wcc * upgrade WCC * add support for prerendering SSR routes with default renderer WCC in favor of puppeteer * document default export * clean up console logging * rollback premature static export feature * use WCC to bundle SSR page routes automatically * roll back native SSR auto hydration * LitElement as SSR page with default export * LitElement as a default export for pages * clarify README example * capture Lit exception for light DOM support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #935
Summary of Changes
default export
syntax for SSR routes to emit a Web Component as body contentexport default
export default .... as HTMLElement
and usage of WCCgetFrontmatter.imports
(YMMV) 🥳TODO
innerHTML
support from wcc (static only mode) - supportinnerHTML
in compiler for custom elements wcc#49prerender
+ puppeteerprerender
option. Do we need to redefineprerender
vsexport
? - will track as part of future release workdefault export
for Lit Renderer PluginQuestions / New Issues
export default
, should find a way to get the tag name automatically, or maybe we don't need it all?prerender
- puppeteer based renderer plugin andHTMLElement
(WCC) as default renderer #954getTemplate
andgetPage
? - Layouts (Templates) and Pages #955default
export allows you to use a custom elementHTMLElement
for all of them?wcc
/HTMLElement
for more advanced casesHTMLElement
(WCC) as default renderer #954<script>
logic / "setup" in a template for SSR (find example)fetch
or GraphQL and if more can be done server side now, e.g.getData()
and passed in as props or serialized asglobalThis
for hydration, a la add support for (progressive) hydration for compatible renderers (globalThis
for state?) #880 , or consider APIs likegetServerSideProps
(SSR) vsgetStaticProps
(SSG) as part of a future data loading story? - Data Loading Strategies #952