-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 1048 handle merging additional Request
/ Response
properties
#1132
Merged
thescientist13
merged 11 commits into
release/0.29.0
from
feature/issue-1048-handle-merging-all-response-properties
Aug 26, 2023
Merged
Feature/issue 1048 handle merging additional Request
/ Response
properties
#1132
thescientist13
merged 11 commits into
release/0.29.0
from
feature/issue-1048-handle-merging-all-response-properties
Aug 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
changed the title
Feature/issue 1048 handle merging all response properties
Feature/issue 1048 handle merging all Aug 10, 2023
Request
/ Response
properties
6 tasks
thescientist13
force-pushed
the
release/0.29.0
branch
from
August 12, 2023 16:03
a00a574
to
69a61ca
Compare
thescientist13
force-pushed
the
feature/issue-1048-handle-merging-all-response-properties
branch
from
August 16, 2023 01:08
0cce9f0
to
199c357
Compare
thescientist13
added
alpha.3
v0.29.0
bug
Something isn't working
and removed
alpha.3
v0.29.0
labels
Aug 16, 2023
thescientist13
changed the title
Feature/issue 1048 handle merging all
Feature/issue 1048 handle merging additional Aug 23, 2023
Request
/ Response
propertiesRequest
/ Response
properties
thescientist13
force-pushed
the
feature/issue-1048-handle-merging-all-response-properties
branch
from
August 26, 2023 16:54
7a68bcc
to
923a416
Compare
thescientist13
deleted the
feature/issue-1048-handle-merging-all-response-properties
branch
August 26, 2023 17:34
thescientist13
added a commit
that referenced
this pull request
Nov 9, 2023
…roperties (#1132) * support merging Response status property * support body on incoming requests * handle merging all custom response headers * lock down content-type headers in test cases * handle Response.statusText property * full response support clean and TODOs cleanup * update vercel adapter plugin specs for request and response handling * update netlify adapter plugin specs for request and response handling * add support for request.formData * add request.formData support to adapter plugins * variable name safe handler alias
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #1048
Summary of Changes
Response
body
(.text()
,.json()
andformData()
) andmethod
onRequest
objectsTODO
Request
properties- Search page withPOST
andFormData
examples thescientist13/greenwood-htmx#3body
headers
query params
Response
propertiesstatus
statusText?return all header, like customx-secret
header in thePOST /api/submit
example in developexecuteRouteModule
API RoutesContent-Type
header, nothing else to support at the moment - https://github.com/ProjectEvergreen/greenwood/blob/v0.29.0-alpha.2/packages/cli/src/lifecycles/bundle.js#L226request.formData
issues/1048
issues/1008
~~multipart/form-data~~
support (nice to have)? - support additionalRequest.body
formats #1147Thoughts / Questions
ctx.request
from Koa, so we can't really flesh out more than this from an initialrequest
. Not sure how much of aRequest
options is ultimately worth merging on or we can even support? Maybe a good discussion topic? - Web Standards Web Server (native `Request` / `Response` support) #1146body
options. Not sure how to best handle / detect them in Koa for serialization though? Options like: - support additionalRequest.body
formats #1147URLSearchParams
Blob