Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/ensure resolving graph.json respects base path configuration #1180

Conversation

thescientist13
Copy link
Member

Related Issue

missed as part of #1116

Summary of Changes

  1. Made sure that resolving graph.json respects basePath configuration
  2. Add test cases for with and without basePath configuration

@thescientist13 thescientist13 added this to the 1.0 milestone Nov 7, 2023
@thescientist13 thescientist13 changed the title ensure resolving graph.json respects base path configuration bug/ensure resolving _graph.json_ respects base path configuration Nov 7, 2023
@thescientist13 thescientist13 changed the title bug/ensure resolving _graph.json_ respects base path configuration bug/ensure resolving graph.json respects base path configuration Nov 7, 2023
@thescientist13 thescientist13 linked an issue Nov 7, 2023 that may be closed by this pull request
3 tasks
@thescientist13 thescientist13 mentioned this pull request Nov 7, 2023
25 tasks
@thescientist13 thescientist13 merged commit ce0c14f into release/0.29.0 Nov 7, 2023
8 checks passed
@thescientist13 thescientist13 deleted the bug/issue-1116-graph-json-not-resolving-relative-to-base-path branch November 7, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

add support for configuring a base path
1 participant