bug/issue 1223 nested SSR pages release branch rebase and refactor #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
changed the title
thescientist13
changed the title
thescientist13
deleted the
bug/issue-1226-nested-ssr-release-branch-rebase-and-refactor
branch
thescientist13
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
as part of rebasing master into the release branch, need to handle a conflict between #1223 / #1186, but mainly wanted to isolate this to a PR to better track the refactor for the benefit of #1223, and kind of works towards #1226
Summary of Changes
pages/ index.js blog/ index.jsWill file a separate PR for actually wrapping up #1226 though after I merge this.