Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement/issue 1178 support all remaining standard pseudo-class and element selectors for CSS bundling #1239

Merged
merged 2 commits into from
Jun 22, 2024
Merged

enhancement/issue 1178 support all remaining standard pseudo-class and element selectors for CSS bundling #1239

merged 2 commits into from
Jun 22, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jun 3, 2024 •
edited
Loading

Related Issue

resolves #1178

Summary of Changes

  1. Adds support for bundling these missing pseudo-classes
    • dir
    • host
    • where
  2. Adds support for bundling these missing pseudo-elements
    • ::highlight
    • ::part
    • ::slotted

TODO

  1. bundling gets :host { } and :host() { } confused and adds unexpected parens () 
    :host(){--primary-color:#16f;--secondary-color:#ff7;}
:host{--primary-color:#16f;--secondary-color:#ff7;}

Opened a discussion about potentially adopting Lightning CSS in a 2.0 version - #1238

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) P0 Critical issue that should get addressed ASAP CLI labels Jun 3, 2024
@thescientist13 thescientist13 linked an issue Jun 3, 2024 that may be closed by this pull request
support all CSS function pseudo classes / elements for CSS optimizing #1178
Closed
@thescientist13 thescientist13 marked this pull request as ready for review June 3, 2024 18:54
@thescientist13 thescientist13 force-pushed the enhancement/issue-1178-css-function-selectors-bundling-support branch from b4b129a to a5ee8fb Compare June 22, 2024 18:24
@thescientist13 thescientist13 merged commit 3180e14 into release/0.30.0 Jun 22, 2024
8 checks passed
@thescientist13 thescientist13 deleted the enhancement/issue-1178-css-function-selectors-bundling-support branch June 22, 2024 18:48
thescientist13 added a commit that referenced this pull request Nov 2, 2024
@thescientist13
enhancement/issue 1178 support all remaining standard pseudo-class an…
61278a1 
…d element selectors for CSS bundling (#1239)

* support pseudo-class and element selectors for CSS bundling

* distinguish between pseudo selectors with and without children
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) P0 Critical issue that should get addressed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support all CSS function pseudo classes / elements for CSS optimizing
1 participant
@thescientist13