Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/issue-1253 misleading init scaffolding instructions #1288

Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Oct 21, 2024

Related Issue

#1253

Noticed the custom app directory option was providing broken instructions

test npx @greenwood/init@alpha my-app
-------------------------------------------------------
Initialize a Greenwood Project ♻️
-------------------------------------------------------
Initializing into project directory... /Users/owenbuckley/Desktop/test/my-app
Initializing project with files...
Creating package.json...
Initializing new project complete!
Change directories by running => cd my-app
To start developing run => npm run dev
➜  test cd my-app
➜  my-app npm run dev

> my-app@1.0.0 dev
> greenwood develop

sh: greenwood: command not found

Summary of Changes

  1. Properly instruct user on next steps (specifically to make sure to install deps)
-------------------------------------------------------
Initialize a Greenwood Project ♻️
-------------------------------------------------------
Initializing into project directory... /Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/init/test/cases/init.project-name/output/my-app
Initializing project with files...
Creating package.json...
Initializing new project complete!
Complete the follow steps to get started:
1) Change directories by running => cd my-app
2) Install dependencies with your package manager, e.g. => npm i
3) To start developing run => npm run dev

@thescientist13 thescientist13 added this to the 1.0 milestone Oct 21, 2024
@thescientist13 thescientist13 changed the title Bug/improper init scaffolding instructions bug/issue 1253 improper init scaffolding instructions Oct 21, 2024
@thescientist13 thescientist13 linked an issue Oct 21, 2024 that may be closed by this pull request
2 tasks
@thescientist13 thescientist13 changed the title bug/issue 1253 improper init scaffolding instructions bug/issue-1253 improper init scaffolding instructions Oct 21, 2024
@thescientist13 thescientist13 changed the title bug/issue-1253 improper init scaffolding instructions bug/issue-1253 misleading init scaffolding instructions Nov 1, 2024
@thescientist13 thescientist13 merged commit 39d0a3c into release/0.30.0 Nov 1, 2024
8 checks passed
@thescientist13 thescientist13 deleted the bug/improper-init-scaffolding-instructions branch November 1, 2024 16:46
thescientist13 added a commit that referenced this pull request Nov 2, 2024
* clearer post init user next steps instructions

* commenting and clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha.8 bug Something isn't working Init v0.30.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

improve init package scaffolding baseline starting point
1 participant