Bug/issue 604 fix json fetch handling #605
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #604
Summary of Changes
originalUrl
as a header to play nicely with make resource resolving more graceful and fallback to originalctx.url
#599 wherein if we have query strings in URLs against the filesystem, then things will break, so need to preserve query params another way?type=json
logic of this will get extracted out into have a plugin for being able toimport
JSON using ESM #516As with anything non standard, this is no "right way" per se to solve this. So far the best hint I can come up with is this
Which takes some influence from a potential standard called import assertions
https://github.com/tc39/proposal-import-assertions
TODO
import
JSON using ESM #516 and other assets like CSS and potentially images - Using `import` for non JavaScript modules #606