Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor root package node modules resolution #725

Merged
merged 3 commits into from
Sep 20, 2021
Merged

refactor root package node modules resolution #725

merged 3 commits into from
Sep 20, 2021

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Sep 13, 2021 •
edited
Loading

Related Issue

re-resolves #557

Summary of Changes

  1. Extract NodeJS require.resolve functionality into a utility
  2. Updated plugin-node_modules.js to leverage shared logic
  3. Updated plugin-polyfills.js to leverage shared logic

TODOs

  1. Update throughout plugin-node-modules.js all cases of path.join where root location is being assumed
  2. Update throughout plugin-polyfills.js where location of @webcomponents/webcomponentsjs is being assumed

@thescientist13 thescientist13 added chore unit testing, maintenance, etc P0 Critical issue that should get addressed ASAP Plugins Greenwood Plugins CLI labels Sep 13, 2021
@thescientist13 thescientist13 self-assigned this Sep 13, 2021
@thescientist13 thescientist13 marked this pull request as ready for review September 13, 2021 19:59
@thescientist13 thescientist13 changed the title refactor root package resolution refactor root package node modules resolution Sep 13, 2021
@thescientist13 thescientist13 removed their assignment Sep 13, 2021
@thescientist13 thescientist13 mentioned this pull request Sep 14, 2021
Merged
2 tasks
@thescientist13 thescientist13 force-pushed the chore/issue-557-node-resolve-refactor-and-missed-use-cases branch from 489c695 to 1bb51fe Compare September 20, 2021 20:47
@thescientist13 thescientist13 merged commit f0b1fcb into master Sep 20, 2021
@thescientist13 thescientist13 deleted the chore/issue-557-node-resolve-refactor-and-missed-use-cases branch September 20, 2021 20:57
@thescientist13 thescientist13 mentioned this pull request Sep 20, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore unit testing, maintenance, etc CLI P0 Critical issue that should get addressed ASAP Plugins Greenwood Plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

leverage NodeJS resolve logic for looking up location of paths for node modules
1 participant
@thescientist13