-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug/issue 532 esm upgrade with fix for windows #814
Merged
thescientist13
merged 11 commits into
chore/issue-532-esm-upgrade
from
chore/issue-532-esm-upgrade-fix-windows
Dec 4, 2021
Merged
bug/issue 532 esm upgrade with fix for windows #814
thescientist13
merged 11 commits into
chore/issue-532-esm-upgrade
from
chore/issue-532-esm-upgrade-fix-windows
Dec 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
bug
Something isn't working
documentation
Greenwood specific docs
Plugins
Greenwood Plugins
CLI
Init
labels
Dec 3, 2021
5 tasks
17 tasks
thescientist13
added a commit
that referenced
this pull request
Dec 4, 2021
* WIP * init upgrade graphql plugin to ESM * fix linting * got develop command working for the website * build command WIP * migrate node module utils to async and refactor require to import.meta * pass linter * remove comment * www/ greenwood build command working * PostCSS working for both develop and build * PostCSS working for both develop and build * async prodServer support * fix serve task not resolving standard web assets * restore plugin analyzer * restore plugin analyzer * restore unified markdown functionality * fix missed merge conflict * restore include HTML plugin * restore polyfills plugin * PostCSS 8 deps upgrades * CLI build default spec passing via ESM * migrtate all CLI specs to ESM and enable eject * fix spec * migrate init package specs to ESM * migrate google and polyfills plugins and specs to ESM * migrate plugin-include-html to ESM * migrate plugin import CSS, JSON, and CommonJS and their specs to ESM * migrate plugin GraphQL and test cases to ESM * migrate plugin GraphQL and unit tests to ESM * migrate plugin typescript and specs to ESM * migrate plugin postcss specs to ESM * migrate plugin babel and default spec case to ESM * update package READMEs for ESM * update docs to demonstrate ESM usage * fix linting * handle path seperator to fix failing spec * bug/issue 532 esm upgrade with fix for windows (#814) * fix greenwood compilation for windows * serve and devekop commands working * default spec passing * proper URL to path handling for cross platform support * all specs passing wiht initial URL refactoring * refactor all specs to new standard URL usage * update docs * fix develop command * wip passing all specs on windows * all commands and tests passing on windows * update theme pack docs
thescientist13
added a commit
that referenced
this pull request
Dec 9, 2021
* WIP * init upgrade graphql plugin to ESM * fix linting * got develop command working for the website * build command WIP * migrate node module utils to async and refactor require to import.meta * pass linter * remove comment * www/ greenwood build command working * PostCSS working for both develop and build * PostCSS working for both develop and build * async prodServer support * fix serve task not resolving standard web assets * restore plugin analyzer * restore plugin analyzer * restore unified markdown functionality * fix missed merge conflict * restore include HTML plugin * restore polyfills plugin * PostCSS 8 deps upgrades * CLI build default spec passing via ESM * migrtate all CLI specs to ESM and enable eject * fix spec * migrate init package specs to ESM * migrate google and polyfills plugins and specs to ESM * migrate plugin-include-html to ESM * migrate plugin import CSS, JSON, and CommonJS and their specs to ESM * migrate plugin GraphQL and test cases to ESM * migrate plugin GraphQL and unit tests to ESM * migrate plugin typescript and specs to ESM * migrate plugin postcss specs to ESM * migrate plugin babel and default spec case to ESM * update package READMEs for ESM * update docs to demonstrate ESM usage * fix linting * handle path seperator to fix failing spec * bug/issue 532 esm upgrade with fix for windows (#814) * fix greenwood compilation for windows * serve and devekop commands working * default spec passing * proper URL to path handling for cross platform support * all specs passing wiht initial URL refactoring * refactor all specs to new standard URL usage * update docs * fix develop command * wip passing all specs on windows * all commands and tests passing on windows * update theme pack docs
thescientist13
added a commit
that referenced
this pull request
Dec 18, 2021
* WIP * init upgrade graphql plugin to ESM * fix linting * got develop command working for the website * build command WIP * migrate node module utils to async and refactor require to import.meta * pass linter * remove comment * www/ greenwood build command working * PostCSS working for both develop and build * PostCSS working for both develop and build * async prodServer support * fix serve task not resolving standard web assets * restore plugin analyzer * restore plugin analyzer * restore unified markdown functionality * fix missed merge conflict * restore include HTML plugin * restore polyfills plugin * PostCSS 8 deps upgrades * CLI build default spec passing via ESM * migrtate all CLI specs to ESM and enable eject * fix spec * migrate init package specs to ESM * migrate google and polyfills plugins and specs to ESM * migrate plugin-include-html to ESM * migrate plugin import CSS, JSON, and CommonJS and their specs to ESM * migrate plugin GraphQL and test cases to ESM * migrate plugin GraphQL and unit tests to ESM * migrate plugin typescript and specs to ESM * migrate plugin postcss specs to ESM * migrate plugin babel and default spec case to ESM * update package READMEs for ESM * update docs to demonstrate ESM usage * fix linting * handle path seperator to fix failing spec * bug/issue 532 esm upgrade with fix for windows (#814) * fix greenwood compilation for windows * serve and devekop commands working * default spec passing * proper URL to path handling for cross platform support * all specs passing wiht initial URL refactoring * refactor all specs to new standard URL usage * update docs * fix develop command * wip passing all specs on windows * all commands and tests passing on windows * update theme pack docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#707
Summary of Changes
__dirname
that doesn't exist anymore. Instead, we should usenew URL
URL
withpath
orimport
, it will be important to usefileURLToPath
orpathToFileURL
, respectively since aFile
's scheme is not consistent across platforms