Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/issue 532 esm upgrade with fix for windows #814

Conversation

thescientist13
Copy link
Member

Related Issue

#707

Summary of Changes

  1. Fixes the build and gets all commands specs passing on Windows and Linux / macOS
  2. Implements a consistent standard for replacing usage of __dirname that doesn't exist anymore. Instead, we should use new URL
  3. In addition, when using a URL with path or import, it will be important to use fileURLToPath or pathToFileURL, respectively since a File's scheme is not consistent across platforms

@thescientist13 thescientist13 added bug Something isn't working documentation Greenwood specific docs Plugins Greenwood Plugins CLI Init labels Dec 3, 2021
@thescientist13 thescientist13 added this to the 1.0 milestone Dec 3, 2021
@thescientist13 thescientist13 linked an issue Dec 3, 2021 that may be closed by this pull request
5 tasks
@thescientist13 thescientist13 mentioned this pull request Dec 3, 2021
17 tasks
@thescientist13 thescientist13 merged commit 2829f7d into chore/issue-532-esm-upgrade Dec 4, 2021
@thescientist13 thescientist13 deleted the chore/issue-532-esm-upgrade-fix-windows branch December 4, 2021 15:56
thescientist13 added a commit that referenced this pull request Dec 4, 2021
* WIP

* init upgrade graphql plugin to ESM

* fix linting

* got develop command working for the website

* build command WIP

* migrate node module utils to async and refactor require to import.meta

* pass linter

* remove comment

* www/ greenwood build command working

* PostCSS working for both develop and build

* PostCSS working for both develop and build

* async prodServer support

* fix serve task not resolving standard web assets

* restore plugin analyzer

* restore plugin analyzer

* restore unified markdown functionality

* fix missed merge conflict

* restore include HTML plugin

* restore polyfills plugin

* PostCSS 8 deps upgrades

* CLI build default spec passing via ESM

* migrtate all CLI specs to ESM and enable eject

* fix spec

* migrate init package specs to ESM

* migrate google and polyfills plugins and specs to ESM

* migrate plugin-include-html to ESM

* migrate plugin import CSS, JSON, and CommonJS and their specs to ESM

* migrate plugin GraphQL and test cases to ESM

* migrate plugin GraphQL and unit tests to ESM

* migrate plugin typescript and specs to ESM

* migrate plugin postcss specs to ESM

* migrate plugin babel and default spec case to ESM

* update package READMEs for ESM

* update docs to demonstrate ESM usage

* fix linting

* handle path seperator to fix failing spec

* bug/issue 532 esm upgrade with fix for windows (#814)

* fix greenwood compilation for windows

* serve and devekop commands working

* default spec passing

* proper URL to path handling for cross platform support

* all specs passing wiht initial URL refactoring

* refactor all specs to new standard URL usage

* update docs

* fix develop command

* wip passing all specs on windows

* all commands and tests passing on windows

* update theme pack docs
thescientist13 added a commit that referenced this pull request Dec 9, 2021
* WIP

* init upgrade graphql plugin to ESM

* fix linting

* got develop command working for the website

* build command WIP

* migrate node module utils to async and refactor require to import.meta

* pass linter

* remove comment

* www/ greenwood build command working

* PostCSS working for both develop and build

* PostCSS working for both develop and build

* async prodServer support

* fix serve task not resolving standard web assets

* restore plugin analyzer

* restore plugin analyzer

* restore unified markdown functionality

* fix missed merge conflict

* restore include HTML plugin

* restore polyfills plugin

* PostCSS 8 deps upgrades

* CLI build default spec passing via ESM

* migrtate all CLI specs to ESM and enable eject

* fix spec

* migrate init package specs to ESM

* migrate google and polyfills plugins and specs to ESM

* migrate plugin-include-html to ESM

* migrate plugin import CSS, JSON, and CommonJS and their specs to ESM

* migrate plugin GraphQL and test cases to ESM

* migrate plugin GraphQL and unit tests to ESM

* migrate plugin typescript and specs to ESM

* migrate plugin postcss specs to ESM

* migrate plugin babel and default spec case to ESM

* update package READMEs for ESM

* update docs to demonstrate ESM usage

* fix linting

* handle path seperator to fix failing spec

* bug/issue 532 esm upgrade with fix for windows (#814)

* fix greenwood compilation for windows

* serve and devekop commands working

* default spec passing

* proper URL to path handling for cross platform support

* all specs passing wiht initial URL refactoring

* refactor all specs to new standard URL usage

* update docs

* fix develop command

* wip passing all specs on windows

* all commands and tests passing on windows

* update theme pack docs
thescientist13 added a commit that referenced this pull request Dec 18, 2021
* WIP

* init upgrade graphql plugin to ESM

* fix linting

* got develop command working for the website

* build command WIP

* migrate node module utils to async and refactor require to import.meta

* pass linter

* remove comment

* www/ greenwood build command working

* PostCSS working for both develop and build

* PostCSS working for both develop and build

* async prodServer support

* fix serve task not resolving standard web assets

* restore plugin analyzer

* restore plugin analyzer

* restore unified markdown functionality

* fix missed merge conflict

* restore include HTML plugin

* restore polyfills plugin

* PostCSS 8 deps upgrades

* CLI build default spec passing via ESM

* migrtate all CLI specs to ESM and enable eject

* fix spec

* migrate init package specs to ESM

* migrate google and polyfills plugins and specs to ESM

* migrate plugin-include-html to ESM

* migrate plugin import CSS, JSON, and CommonJS and their specs to ESM

* migrate plugin GraphQL and test cases to ESM

* migrate plugin GraphQL and unit tests to ESM

* migrate plugin typescript and specs to ESM

* migrate plugin postcss specs to ESM

* migrate plugin babel and default spec case to ESM

* update package READMEs for ESM

* update docs to demonstrate ESM usage

* fix linting

* handle path seperator to fix failing spec

* bug/issue 532 esm upgrade with fix for windows (#814)

* fix greenwood compilation for windows

* serve and devekop commands working

* default spec passing

* proper URL to path handling for cross platform support

* all specs passing wiht initial URL refactoring

* refactor all specs to new standard URL usage

* update docs

* fix develop command

* wip passing all specs on windows

* all commands and tests passing on windows

* update theme pack docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha.0 bug Something isn't working CLI documentation Greenwood specific docs Init Plugins Greenwood Plugins v0.20.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade project codebase to ESM
1 participant