Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue 140 adopt ESM and bundler friendly fork of escodegen #141

Merged
merged 8 commits into from
Mar 9, 2024
Merged

Feature/issue 140 adopt ESM and bundler friendly fork of escodegen #141

merged 8 commits into from
Mar 9, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Feb 10, 2024 •
edited
Loading

Related Issue

resolves #140

Summary of Changes

  1. Refactor for ESM ecodegen API and update rollup.config.js to validate
  2. Drop json Rollup plugin
  3. Upgrade to Rollup 3.x

Will break because escodegen needs type="module" and patch-package does not track package.json change, so it will have to be done manually for testing locally

TODO

  1. Fork and patch with package.json changes
    • type="module"
    • engines >= 18.x
    • export maps
  2. When will Rollup support import assertions? v4 no longer allows custom acorn plugins - not right now
  3. Test in upstream in Greenwood - feature/issue 1197 Lit v3 upgrade and SSR fixes and enhancements greenwood#1201
  4. Clean up comments and prepare for merge

@thescientist13 thescientist13 added feature New feature or request question Further information is requested labels Feb 10, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 10, 2024 •
edited
Loading

❌ Deploy Preview for merry-caramel-524e61 failed.

Name Link
🔨 Latest commit 7baf581
🔍 Latest deploy log https://app.netlify.com/sites/merry-caramel-524e61/deploys/65c8119b29b3810008055d2b

@thescientist13 thescientist13 self-assigned this Feb 10, 2024
@thescientist13 thescientist13 changed the title Feature/issue 140 esm escodegen Feature/issue 140 vendor esm escodegen fork Feb 10, 2024
@thescientist13 thescientist13 changed the title Feature/issue 140 vendor esm escodegen fork Feature/issue 140 vendor ESM and bundler friendly escodegen fork Feb 11, 2024
This was referenced Feb 11, 2024
Closed
Merged
@thescientist13 thescientist13 marked this pull request as ready for review February 11, 2024 01:18
@thescientist13 thescientist13 removed the question Further information is requested label Feb 11, 2024
@thescientist13 thescientist13 mentioned this pull request Feb 27, 2024
Merged
16 tasks
@thescientist13 thescientist13 changed the title Feature/issue 140 vendor ESM and bundler friendly escodegen fork Feature/issue 140 adopt ESM and bundler friendly fork of escodegen Mar 9, 2024
@thescientist13 thescientist13 force-pushed the feature/issue-140-esm-escodegen branch from 9714261 to c2c71ef Compare March 9, 2024 19:24
@thescientist13 thescientist13 merged commit 61492ca into master Mar 9, 2024
12 checks passed
@thescientist13 thescientist13 deleted the feature/issue-140-esm-escodegen branch March 9, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adopt a bundle friendly and ESM compatible fork of escodegen
1 participant
@thescientist13