Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/issue 47 updated greenwood logo #64

Merged
merged 10 commits into from
Jul 11, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jun 24, 2024

Related Issue

resolves #47

Screenshot 2024-07-03 at 8 54 18 AM
Screenshot 2024-07-03 at 8 54 37 AM
Screenshot 2024-07-03 at 8 54 46 AM

Summary of Changes

  1. Source original SVG contents of the Greenwood logo with variants
  2. Integrate / customize logo into the Header and Footer components
  3. Header styles cleanup and responsive tweaks
  4. Documented logo colors

TODO

  1. SVG seems to missing the two / tone color with a "light half"
  2. header integration and font color change - light vs shadow dom styles :/
  3. Handle CSS Modules plugin mangling of class selector lists
    /* input */
    .logo svg g.letters {
      fill: red;
    }
    
    /* output */
    .footer-343286999-logo svg g.footer-343286999-letters {
      fill: red;
    }
    
    /* expected */
    .footer-343286999-logo svg g.letters {
      fill: red;
    }

Questions

  1. font family and line-height alignment (just have it all baked into the SVG, even the text?)

Unrelated to this PR, but it seems SVGs are not triggering a live reload?

@thescientist13 thescientist13 added bug Something isn't working enhancement New feature or request labels Jun 24, 2024
Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for super-tapioca-5987ce ready!

Name Link
🔨 Latest commit f2c5e1c
🔍 Latest deploy log https://app.netlify.com/sites/super-tapioca-5987ce/deploys/668ff5a63ea15b0008ce646b
😎 Deploy Preview https://deploy-preview-64--super-tapioca-5987ce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thescientist13 thescientist13 changed the title Bug/issue 47 updated greenwood logo bug/issue 47 updated greenwood logo Jun 24, 2024
@thescientist13 thescientist13 added needs upstream Notes that this item exposes an issue with a dependency (usually Greenwood) question Further information is requested docs Greenwood specific content like docs and guides and removed question Further information is requested needs upstream Notes that this item exposes an issue with a dependency (usually Greenwood) labels Jun 26, 2024
@thescientist13 thescientist13 marked this pull request as ready for review June 28, 2024 21:28
Copy link
Contributor

@Auhseh Auhseh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking Good

@thescientist13 thescientist13 force-pushed the bug/issue-47-updated-greenwood-logo branch from dcd0061 to f2c5e1c Compare July 11, 2024 15:09
@thescientist13 thescientist13 merged commit 306a78e into main Jul 11, 2024
5 checks passed
@thescientist13 thescientist13 deleted the bug/issue-47-updated-greenwood-logo branch July 11, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Greenwood specific content like docs and guides enhancement New feature or request
Projects
None yet
2 participants