Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VLCTY-906: IAM role migration: move to github-actions role in Prod-CI account (from infra account) #5

Closed
wants to merge 1 commit into from

Conversation

nsheaps
Copy link

@nsheaps nsheaps commented Jul 27, 2023

IAM ROLE MIGRATION PARTY 🎉

This PR updates the the role-to-assume role used in the aws-actions/configure-aws-credentials@v2 to a new role in the Prod-CI account

This consistency will help us

  • make org-wide changes if we need to move it again
  • uses an org env var instead of secret to keep it visible
  • moves CI compontents into a consistent account, splitting it from infra use

How was this tested?

Testing happened in this PR as part of the workflow. Any default-branch-only or label-based workflows were not tested as part of this automated change

Notes

  • This change is independent of any permissions associated with the new or old role and should be revertable if it causes any problems

@nsheaps nsheaps force-pushed the migrate-to-ci-acct-iam-role branch 2 times, most recently from 626fcc5 to 76c0b4d Compare July 27, 2023 20:24
@nsheaps nsheaps changed the title IAM role migration: move to github-actions role in Prod-CI account (from infra account) VLCTY-906: IAM role migration: move to github-actions role in Prod-CI account (from infra account) Jul 28, 2023
@nsheaps nsheaps force-pushed the migrate-to-ci-acct-iam-role branch from 76c0b4d to 3fbf630 Compare July 28, 2023 16:38
@nsheaps nsheaps force-pushed the migrate-to-ci-acct-iam-role branch from 3fbf630 to 07dac0e Compare July 28, 2023 18:55
@nsheaps nsheaps closed this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant