Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make postinstall script nonblocking on error #1015

Merged
merged 2 commits into from
Jun 1, 2023
Merged

make postinstall script nonblocking on error #1015

merged 2 commits into from
Jun 1, 2023

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented Jun 1, 2023

No description provided.

@ryanio ryanio requested a review from a team June 1, 2023 02:51
@ryanio ryanio mentioned this pull request Jun 1, 2023
Closed
JoshuaSchmidt-OpenSea
JoshuaSchmidt-OpenSea approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@JoshuaSchmidt-OpenSea JoshuaSchmidt-OpenSea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also bump the patch version 6.0.1 so people can consume it

@JoshuaSchmidt-OpenSea JoshuaSchmidt-OpenSea merged commit 3d1cbd1 into main Jun 1, 2023
@JoshuaSchmidt-OpenSea JoshuaSchmidt-OpenSea deleted the ryan/make-postinstall-script-nonblocking branch June 1, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaSchmidt-OpenSea JoshuaSchmidt-OpenSea JoshuaSchmidt-OpenSea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanio @JoshuaSchmidt-OpenSea @thenerdassassin