Fixes underflow when try to use fractional ETH as number in orders #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanio
reviewed
Jun 8, 2023
test/integration/postOrder.spec.ts
Outdated
| @@ -34,7 +34,7 @@ suite("SDK: order posting", () => { | |||
|
|
|||
| const sellOrder = { | |||
| accountAddress: walletAddress, | |||
| startAmount: LISTING_AMOUNT, | |||
| startAmount: +LISTING_AMOUNT, | |||
There was a problem hiding this comment.
maybe keep one as a string or it might be smart to test all variations of bignumberish inputs to ensure their resulting values are equal
ryanio
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #1022
Solution
BigNumberish was being parsed as FixedNumber and cast to string. Instead casted BigNumberish to string directly.
Testing
Changed integration tests to use numbers instead of strings.