Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 4 new endpoints and support multichain #1055

Merged
merged 7 commits into from
Jul 6, 2023
Merged

Add 4 new endpoints and support multichain #1055

merged 7 commits into from
Jul 6, 2023

Conversation

thenerdassassin
Copy link
Contributor

Motivation

The API has added 4 new multichain endpoints which are being implemented here:

  • List NFTS by Collection
  • List NFTS by Contract
  • Get an NFT
  • Refresh Metadata for an NFT

@thenerdassassin thenerdassassin requested a review from a team June 29, 2023 14:23
thenerdassassin
thenerdassassin commented Jun 29, 2023
View reviewed changes
src/constants.ts Outdated Show resolved Hide resolved
thenerdassassin
thenerdassassin commented Jun 29, 2023
View reviewed changes
src/sdk.ts Outdated Show resolved Hide resolved
cterech
cterech approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@cterech cterech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - should we add methods in top level sdk.ts for listing / getting nfts?

ryanio
ryanio reviewed Jun 29, 2023
View reviewed changes
src/api/api.ts Show resolved Hide resolved
ryanio
ryanio reviewed Jun 29, 2023
View reviewed changes
src/sdk.ts Outdated Show resolved Hide resolved
ryanio
ryanio reviewed Jun 29, 2023
View reviewed changes
src/api/api.ts Outdated Show resolved Hide resolved
@thenerdassassin thenerdassassin requested a review from ryanio June 29, 2023 19:30
ryanio
ryanio reviewed Jun 30, 2023
View reviewed changes
src/types.ts Outdated Show resolved Hide resolved
ryanio
ryanio reviewed Jun 30, 2023
View reviewed changes
src/types.ts Outdated Show resolved Hide resolved
This was referenced Jul 3, 2023
Closed
Closed
thenerdassassin and others added 4 commits July 5, 2023 13:30
@thenerdassassin @ryanio
Update src/types.ts
8a7b41d 
Co-authored-by: Ryan Ghods <ralxzryan@gmail.com>
@thenerdassassin @ryanio
Update src/types.ts
3ddc969 
Co-authored-by: Ryan Ghods <ralxzryan@gmail.com>
@thenerdassassin
Merge branch 'main' into multichainNFTs
15f3385
@thenerdassassin
Update chain enum
688a7ca
@thenerdassassin thenerdassassin merged commit 3ab45e7 into main Jul 6, 2023
@thenerdassassin thenerdassassin deleted the multichainNFTs branch July 6, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanio ryanio ryanio approved these changes

@cterech cterech cterech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thenerdassassin @ryanio @cterech