-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove wyvern-schemas package #872
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cterech
reviewed
Mar 10, 2023
cterech
reviewed
Mar 10, 2023
cterech
reviewed
Mar 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few higher level comments
- can we get rid of the collection specific definitions? i.e. why do we need a CryptoKitties schema?
- is it a lot of additional work to remove all of the references to Rinkeby?
- (this might be a dumb question) - instead of copying and pasting all of these object definitions, is there a way we can define our own minimal set of schemas and use those?
I think we will be able to remove CryptoPunks, Rinkeby and possible a set of the schemas and tokens. However, I would like to not make any changes to the logic in this PR since it is already massive just by removing the package. |
montasaurus
approved these changes
Mar 10, 2023
cterech
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing this package fixes known security issues with the version of
axios
used by the wyvern-schemas package