Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wyvern-schemas package #872

Merged
merged 7 commits into from
Mar 10, 2023
Merged

Remove wyvern-schemas package #872

merged 7 commits into from
Mar 10, 2023

Conversation

JoshuaSchmidt-OpenSea
Copy link
Contributor

Removing this package fixes known security issues with the version of axios used by the wyvern-schemas package

@JoshuaSchmidt-OpenSea JoshuaSchmidt-OpenSea requested a review from a team March 9, 2023 19:39
Copy link
Collaborator

@cterech cterech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few higher level comments

  1. can we get rid of the collection specific definitions? i.e. why do we need a CryptoKitties schema?
  2. is it a lot of additional work to remove all of the references to Rinkeby?
  3. (this might be a dumb question) - instead of copying and pasting all of these object definitions, is there a way we can define our own minimal set of schemas and use those?

@JoshuaSchmidt-OpenSea
Copy link
Contributor Author

few higher level comments

  1. can we get rid of the collection specific definitions? i.e. why do we need a CryptoKitties schema?
  2. is it a lot of additional work to remove all of the references to Rinkeby?
  3. (this might be a dumb question) - instead of copying and pasting all of these object definitions, is there a way we can define our own minimal set of schemas and use those?

I think we will be able to remove CryptoPunks, Rinkeby and possible a set of the schemas and tokens. However, I would like to not make any changes to the logic in this PR since it is already massive just by removing the package.

package.json Outdated Show resolved Hide resolved
@JoshuaSchmidt-OpenSea JoshuaSchmidt-OpenSea merged commit 1392462 into master Mar 10, 2023
@JoshuaSchmidt-OpenSea JoshuaSchmidt-OpenSea deleted the securityFixes branch March 10, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants