Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale tip amounts to partial fills when using fulfillOrders (fulfillAvailableAdvancedOrders) #558

Closed
2 tasks done
frankisawesome opened this issue May 29, 2024 · 0 comments · Fixed by #559
Closed
2 tasks done

Scale tip amounts to partial fills when using fulfillOrders (fulfillAvailableAdvancedOrders) #558

frankisawesome opened this issue May 29, 2024 · 0 comments · Fixed by #559
Labels
bug Something isn't working

Comments

@frankisawesome
Copy link
Contributor

Component

API

Have you ensured that all of these are up to date?

  • seaport-js
  • Node (minimum v16)

What version of seaport-js are you on?

latest

What function is the bug in?

fulfillOrders

Operating System

None

Describe the bug

When calling fulfillOrders with a partial order fulfillment and using a tip, the tip amount is not scaled to the fulfillment proportion. This behaviour was fixed in fulfillOrder.

I intend to have a PR shortly fixing this 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(fix) Fix tip amount scaling in fulfillOrders frankisawesome/seaport-js
1 participant
@frankisawesome