Merge pull request #351 from Proteobench/peptidoform

Fix GH
Proteobench · Sep 2, 2024 · 0848925 · 0848925
2 parents 9a9ce1d + f434c4b
commit 0848925
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/docs/Instructions_new_module.docx b/docs/Instructions_new_module.docx
diff --git a/docs/Instructions_new_module.pdf b/docs/Instructions_new_module.pdf
diff --git a/proteobench/modules/dda_quant_base/module.py b/proteobench/modules/dda_quant_base/module.py
@@ -169,7 +169,7 @@ def clone_pr(
 
         branch_name = current_datapoint["id"]
 
-        path_write = os.path.join(self.t_dir, "results.json")
+        path_write = os.path.join(self.t_dir_pr, "results.json")
         logging.info(f"Writing the json to: {path_write}")
         f = open(path_write, "w")
 
@@ -189,8 +189,7 @@ def clone_pr(
         return "https://" + remote_git.replace(".git", "") + "/pull/" + str(pr_id)
 
     def write_json_local_development(self, temporary_datapoints, datapoint_params):
-        t_dir = TemporaryDirectory().name
-        os.mkdir(t_dir)
+        os.mkdir(self.t_dir_pr)
 
         current_datapoint = temporary_datapoints.iloc[-1]
 
@@ -202,14 +201,14 @@ def write_json_local_development(self, temporary_datapoints, datapoint_params):
         all_datapoints = self.add_current_data_point(None, current_datapoint)
 
         # TODO write below to logger instead of std.out
-        fname = os.path.join(t_dir, "results.json")
+        fname = os.path.join(self.t_dir_pr, "results.json")
         logging.info(f"Writing the json to: {fname}")
 
-        f = open(os.path.join(t_dir, "results.json"), "w")
+        f = open(os.path.join(self.t_dir_pr, "results.json"), "w")
 
         all_datapoints.to_json(f, orient="records", indent=2)
 
-        return os.path.join(t_dir, "results.json")
+        return os.path.join(self.t_dir_pr, "results.json")
 
     def write_intermediate_raw(self, dir, ident, input_df, result_performance, param_loc):
         path_write = os.path.join(dir, ident)