Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix FragPipe parameter parsing #302

Merged
merged 4 commits into from
May 25, 2024

Conversation

enryH
Copy link
Member

@enryH enryH commented May 17, 2024

Windows path in fragpipe_win_path.workflow correctly interpreted on Windows, but will probably fail on UNIX servers...

Start with adding a new test.

Solve issue #285

@enryH enryH added the bug Something isn't working label May 17, 2024
@enryH enryH self-assigned this May 17, 2024
@enryH enryH marked this pull request as ready for review May 19, 2024 15:42
Henry added 2 commits May 19, 2024 17:43
- windows path in fragpipe_win_path.workflow correctly interpreted on Windows, but will probably fail on UNIX servers...
- maps both Posix and Windows path correctly: https://stackoverflow.com/a/73682980
@enryH enryH force-pushed the fragpipe_parse_win_path_on_unix branch from 0e3a3a0 to 4c21757 Compare May 19, 2024 15:43
@RobbinBouwmeester RobbinBouwmeester merged commit 8b1ea25 into main May 25, 2024
8 checks passed
@RobbinBouwmeester RobbinBouwmeester deleted the fragpipe_parse_win_path_on_unix branch May 25, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error during submission of FragPipe output/FragPipe - MSFragger version number
3 participants