Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Add current proteobench version to landing page of UI #313

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

enryH
Copy link
Member

@enryH enryH commented May 31, 2024

No description provided.

@enryH enryH requested review from mlocardpaulet and RobbinBouwmeester and removed request for mlocardpaulet May 31, 2024 15:14
@enryH enryH requested a review from mlocardpaulet June 2, 2024 14:21
@mlocardpaulet
Copy link
Contributor

It works when I run it locally. I have this in the main page:
image
My question is: why 0.2.7b0?
It should be higher, no?
In the CHANGELOG.md that I have, the head of the file is:

# Changelog

All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.2.9] - 2024-05-21

...

Is this normal?

@mlocardpaulet
Copy link
Contributor

mlocardpaulet commented Jun 2, 2024

Additional question: currently, when I click on the link to documentation from proteobench.cubimed, I reach the latest version. Can I just change the link to https://proteobench.readthedocs.io/en/stable/ in the home page? Would you mind? This way it is consistent.

@julianu
Copy link
Contributor

julianu commented Jun 3, 2024

Actually, the last release (on GitHub) is 0.2.7, which is also installed on the server right now. On PyPi, there is 0.2.8b0, which seems a bit inconsistent.

@enryH
Copy link
Member Author

enryH commented Jun 4, 2024

I guess this is because there are only pre-releases on PyPI: https://pypi.org/project/proteobench/#history

setuptools-scm picks it up from the last tag/release in the repository.

@RobbinBouwmeester Do you know why?

We could also switch to a different PyPI release workflow if that is needed.

@enryH
Copy link
Member Author

enryH commented Jun 4, 2024

Additional question: currently, when I click on the link to documentation from proteobench.cubimed, I reach the latest version. Can I just change the link to https://proteobench.readthedocs.io/en/stable/ in the home page? Would you mind? This way it is consistent.

The default version on readthedocs is the stable one: https://proteobench.readthedocs.io

So yes, go ahead

@enryH
Copy link
Member Author

enryH commented Jun 4, 2024

It works when I run it locally. I have this in the main page: image My question is: why 0.2.7b0? It should be higher, no? In the CHANGELOG.md that I have, the head of the file is:

# Changelog

All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.2.9] - 2024-05-21

...

Is this normal?

So the answer is: The actions which is updating PyPI is failing: https://github.com/Proteobench/ProteoBench/actions/workflows/automated_release.yml

It complains about the Changelog.md file:

FATAL error reading changelog: changelog file does not contain version 0.2.9 

The build version is however 0.2.8

Version number normalised: '0.2.8-beta' -> '0.2.8b0' (see PEP 440)
Successfully built proteobench-0.2.8b0-py3-none-any.whl

With the beta suffix.

So I guess we need to figure that out before on the main branch.

@enryH
Copy link
Member Author

enryH commented Jun 4, 2024

It added now also the intermediate version to the Changelog: #315

@mlocardpaulet
Copy link
Contributor

Additional question: currently, when I click on the link to documentation from proteobench.cubimed, I reach the latest version. Can I just change the link to https://proteobench.readthedocs.io/en/stable/ in the home page? Would you mind? This way it is consistent.

The default version on readthedocs is the stable one: https://proteobench.readthedocs.io

So yes, go ahead

done.

@enryH
Copy link
Member Author

enryH commented Jun 5, 2024

Then you can approve and merge:)

@mlocardpaulet mlocardpaulet merged commit 3ca2d02 into main Jun 7, 2024
8 checks passed
@mlocardpaulet mlocardpaulet deleted the show_version_in_UI branch June 7, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants