Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 update publishing workflow #318

Merged
merged 3 commits into from
Jul 12, 2024
Merged

🐛 update publishing workflow #318

merged 3 commits into from
Jul 12, 2024

Conversation

enryH
Copy link
Member

@enryH enryH commented Jun 14, 2024 •
edited
Loading

  • see if flit-scm helps, otherwise change workflow to twine...

🐛 see if flit-scm works
cf6172a 
- otherwise change workflow to twine...
@enryH enryH changed the title 🐛 see if flit-scm works 🐛 update publishing workflow Jun 14, 2024
@enryH enryH marked this pull request as ready for review June 14, 2024 09:56
@enryH
Copy link
Member Author

enryH commented Jun 14, 2024

Change the publishing workflow to be compatible with setuptools-scm, which is based on using importlib.metadata.

🚧 add testing to publishing workflow
31e7163 
- leave artefact upload to action
- will only be tested if release is triggered
@enryH enryH merged commit d6a0baf into main Jul 12, 2024
8 checks passed
@enryH enryH deleted the pypi_publish branch July 12, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlocardpaulet mlocardpaulet mlocardpaulet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enryH @mlocardpaulet