Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation and docstrings, improve DIA-NN parsing, refactoring #378

Merged
merged 50 commits into from
Sep 5, 2024

Conversation

Cajac102
Copy link
Contributor

@Cajac102 Cajac102 commented Sep 4, 2024

No description provided.

try:
intermediate_data_structure = quant_score.generate_intermediate(standard_format, replicate_to_raw)
except Exception as e:
raise IntermediateFormatGenerationError(f"Error generating intermediate data structure: {e}")

# try:
#try:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncomment

current_datapoint = Datapoint.generate_datapoint(
intermediate_data_structure, input_format, user_input, default_cutoff_min_prec=default_cutoff_min_prec
)
# except Exception as e:
#except Exception as e:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncomment

@rodvrees
Copy link
Contributor

rodvrees commented Sep 5, 2024

@SamvPy @Cajac102 @Alirezak2n I added our names to the contribution, can you check if I added your stuff correctly?
https://github.com/Proteobench/ProteoBench/blob/DIA/docs/index.rst

@RobbinBouwmeester RobbinBouwmeester merged commit 5000a0f into main Sep 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants