Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show submission comment instead of additional comment for public runs. #382

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Show submission comment instead of additional comment for public runs. #382

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61950aa
Show submission comment instead of additional comment for public runs.
scaramonche Sep 5, 2024
631603e
Remove print line.
scaramonche Sep 5, 2024
5b3c9c5
Merge branch 'main' into show-submission-comment
RobbinBouwmeester Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions proteobench/plotting/plot_quant.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ def plot_metric(
Return: Plotly figure object

"""
# TODO Shouldnt this use the weighted sum?
all_median_abs_epsilon = [
v2["median_abs_epsilon"] for v in benchmark_metrics_df["results"] for v2 in v.values()
]
Expand All @@ -117,7 +116,8 @@ def plot_metric(

if "comments" in benchmark_metrics_df.columns:
hover_texts = [
v + f"Comment: {c[0:75]}" for v, c in zip(hover_texts, benchmark_metrics_df.comments.fillna(""))
v + f"Comment: {c[0:75]}"
for v, c in zip(hover_texts, benchmark_metrics_df.submission_comments.fillna(""))
]

scatter_size = [mapping[item] for item in benchmark_metrics_df["old_new"]]
Expand Down
Loading