MSAID output compatibility #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rodvrees ready to merge? |
|
@RobbinBouwmeester Yes, I'm ready! |
RobbinBouwmeester
requested changes
Nov 7, 2024
RobbinBouwmeester
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a Jupyter Notebook to prepare MSAID output: protein information is not added to precursor information, only an ID. The Jupyter Notebook adds protein information based on the protein ids from proteingroups.tsv
Also converts extracted param: 'quantification_method_DIANN' into 'quantification_method'. Was originally meant specifically for different quant methods implemented in DIA-NN, but MSAID also has a bunch of quantification options, so makes sense to generalize the param.
Also includes a fix that allows output of AlphaDIA two-step search, where it can happen that species information from fasta gets lost