-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spectronaut params #437
Spectronaut params #437
Conversation
Analysis Date: 08-November-2024 11:46:55 UTC+0 | ||
|
||
|
||
[BEGIN-SETTINGS] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing how so many can have custom format. I guess this for human readability. Should we ask them if they also have a machine readable version?
quantification_method,MS2 | ||
second_pass,directDIA+ (Deep) | ||
protein_inference,IDPicker | ||
predictors_library,: False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be parsed better?
test/params/spectronaut_Experiment1_ExperimentSetupOverview_BGS_Factory_Settings.csv
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of the parameters need a bit of stripping. and I think for a future iterations we might ask for an easier format - I imagine this can easily lead to a fragile parsing experience when they update their log.
Co-authored-by: Henry Webel <heweb@dtu.dk>
@enryH, they are now parsed better. I sent an email to BGS support and asked for a machine-readable format and if they could report a number instead of "System Default." But for now, it's how it is. |
This is what BGS support writes: In the case of MS1/MS2 Mass Tolerance Strategy, the System Default values can be found by hovering over the setting name. Additionally, this information can be found in the Spectronaut user manual. As you can see, this value depends on the type of mass analyzer used in the experiment. I will replace System Default with 40ppm. |
This pull request implements the parsing of spectronaut parameters.