Add protein columns to alphadia and spectronaut TOMLs #445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because some DIA search engines parse fasta headers themselves and sometimes lose species info in output, we previously implemented a mapping function to map gene names to correct fasta header info, including species info. This way we added a new protein column to the intermediate format, which negated the need to add a specified protein column in the search engine-specific TOML (because default name was used).
As per @mlocardpaulet's suggestion, we should still include protein column name information in the tomls, to avoid confusion as to which column exactly is used.
The easiest fix would be to just keep the functionality the same, but do the mapping within the original column instead of making a new "Proteins" column. In this way, the original column name can be specified in the .toml
Let me know if this approach is okay