Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add MFS tutorial #200
feat: add MFS tutorial #200
Changes from 69 commits
1493427
21e0e81
0316e88
c80c954
bd96f59
db8d2c7
ff96c55
a126b30
c500fd4
8b00bb8
196593e
ecea23b
fa33bee
78d9639
6e201df
4c356ca
09e2af0
b786fbb
39e139a
888dfee
45cec48
424c0a6
8f7872c
6e4cae3
9f9281f
d293b45
0906027
2ed5e24
e401847
6655da7
ced1bb8
e513197
2a4a272
d78057b
66592b6
e5d8d94
1473267
66c06e5
5347613
d1abb57
13cdf99
158cbc4
6aff4e1
d78163f
48e6a9b
45ac12e
e03f04a
e81939c
312c243
e306c48
3314cbf
812e4e7
f751225
5e26cea
e9ec6ff
05e5bc7
7f49d1e
4cb1298
ce71d33
4b84b75
13ad8f5
bc3ff5e
3fc3726
e342f59
b547b15
8dce93f
6b17177
32181d0
c33cfc1
6b9b527
b517b9d
3b02330
b7fa36d
57881c7
a9c0350
97a94e8
5b17226
7ee253b
eef27cd
53bdd02
8a6c254
b9ffb61
1c0c52b
f5d62e8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand this sentence...is it referring to the difference between running a daemon on your machine and running it in the browser?
I think this could be confusing to people, the browser is running on my machine, so how is IPFS not running on my machine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think @terichadbourne was trying to differentiate between having to install IPFS and run a daemon in your terminal from running an on-demand disposable one in the browser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, so essentially you can do all of ProtoSchool without ever learning to install IPFS. So we need to call out that we're skipping a whole step... which I can't describe accurately because I'm never done it NOT in the browser. Want to propose something that sounds accurate to you while still explaining what we're doing in the background?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps needs a rephrase? When running IPFS in the browser it is running locally as well, it's just running in your browser's sandbox.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never done it the other way, so perhaps you can help me describe it more accurately. Would it be "eventually you'll need to learn to IPFS and run a daemon in your terminal"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know how this sounds to you @alanshaw. Does it address your concerns?