Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[2.29.0] - 2024-10-01
Thanks to: @bugsounet, @dkallen78, @jargordon, @khassel, @KristjanESPERANTO, @MarcLandis, @rejas, @ryan-d-williams, @sdetweil, @skpanagiotis.
Added
npm run test:spelling
and handle spelling issues (Add spell check MagicMirrorOrg/MagicMirror#3544)config.paths.vendor
(could not work becausevendor
is hardcoded inindex.html
), renamedconfig.paths.modules
toconfig.foreignModulesDir
, added variableMM_CUSTOMCSS_FILE
which - if set - overridesconfig.customCss
, added variableMM_MODULES_DIR
which - if set - overridesconfig.foreignModulesDir
, added test forMM_MODULES_DIR
(add new env vars MM_MODULES_DIR and MM_CUSTOMCSS_FILE … MagicMirrorOrg/MagicMirror#3530)index.html
when loading script or stylesheet files failsMODULE_DOM_UPDATED
notification each time the DOM is re-rendered viaupdateDom
(Notification on subsequent DOM updates (not just the first) MagicMirrorOrg/MagicMirror#3534)node-libgpiod
library to electron-rebuild tests (Electron rebuild tests update MagicMirrorOrg/MagicMirror#3563)Removed
eslint-plugin-import
, because it doesn't support ESLint v9. We will reenter it later when it does.onoff
library from electron-rebuild tests (Electron rebuild tests update MagicMirrorOrg/MagicMirror#3563)Updated
apiVersion
default from 2.5 to 3.0 ([weather] openweathermap One Call 2.5 will be finally closed in June 2024 MagicMirrorOrg/MagicMirror#3424)node-ical
version to0.18.0
with exceptionallow-ghsas: GHSA-8hc4-vh64-cxmj
indep-review.yaml
(which should removed after nextnode-ical
update)config_check.js
package.json
(currently v20.9.0) (Updated minimal needed node version inpackage.json
(currently v20.9.0) MagicMirrorOrg/MagicMirror#3559) and except for v21 (no security updates) (Engine except on node v21 MagicMirrorOrg/MagicMirror#3561)eslint-plugin-unicorn
by@eslint/js
Fixed
checks
badge in README.mdjs/positions.js
when linting (this file is created at runtime)Hello and thank you for wanting to contribute to the MagicMirror² project
Please make sure that you have followed these 4 rules before submitting your Pull Request:
Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of
develop
before creating apull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.
Thanks again and have a nice day!