Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Char Type Inference #942

Closed
9 tasks done
gluax opened this issue May 11, 2021 · 0 comments · Fixed by #957
Closed
9 tasks done

[Feature] Char Type Inference #942

gluax opened this issue May 11, 2021 · 0 comments · Fixed by #957
Assignees
Labels
feature A new feature.

Comments

@gluax
Copy link
Contributor

gluax commented May 11, 2021

🚀 Feature

The goal is to add char to the Phases Reducer, allowing type-inference to handle characters.
Depends on #939.

Motivation

Right now, each of the AST and ASG relies on a reducer to handle certain phases such as canonicalization, type inference, etc.
The goal is to update the Reducer, allowing the type-inference phase, and we can now compile Leo.

Implementation

Type Inference

  • The reduce_value function will need to match on ConstValue::Char to resolve the type leo/compiler/src/phases/reducing_director.rs.

Tests

  • Compiler Tests:
    • Assigning a char.
      • Explicit.
      • Non-Explicit. Type Inference Should be tested here as well.
    • Passing a char to functions.
    • Circuit member variable char fields.
    • Input
    • Output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant