Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] String Implementation #929

Closed
29 tasks done
Protryon opened this issue May 7, 2021 · 7 comments
Closed
29 tasks done

[Epic] String Implementation #929

Protryon opened this issue May 7, 2021 · 7 comments
Labels
feature A new feature.

Comments

@Protryon
Copy link
Contributor

Protryon commented May 7, 2021

@Protryon Protryon added the feature A new feature. label May 7, 2021
@acoglio
Copy link
Collaborator

acoglio commented May 7, 2021

In regard to 'char type as alias for field', I'd like to make sure we are all on the same page. According to the RFC, and I believe previous discussions, char is a separate type from field, at the Leo language level. Concretely:

let c:char = 3field; // type error
let c:char = 3field as char; // legal when we have type casts

We implement char as field values (in the range 0 to 10FFFF) in R1CS, similarly to how we implement bool as field values (in the range 0 to 1), but char, bool, and field are all separate types. In particular, the type inference will need a small extension to handle the new type char. (Having a separate char type also leaves the door open to a different R1CS representation in the future, should that prove useful.)

@acoglio
Copy link
Collaborator

acoglio commented May 7, 2021

I expanded and reordered @Protryon's initial list. Feedback/amendments welcome as usual.

@damirka
Copy link
Contributor

damirka commented May 11, 2021

Updated task description, added links to sub issues for easier access.

@damirka
Copy link
Contributor

damirka commented May 26, 2021

@acoglio I've marked resolved issues. Only two we got left are:

@acoglio
Copy link
Collaborator

acoglio commented May 26, 2021

@damirka Thanks, I've merged the ABNF PR and checked off the item.

@damirka
Copy link
Contributor

damirka commented May 27, 2021

Sent documentation update to welcome branch. So this epic can be considered complete once we have new Leo release.

@acoglio
Copy link
Collaborator

acoglio commented Jun 1, 2021

This is now complete.

@acoglio acoglio closed this as completed Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature.
Projects
None yet
Development

No branches or pull requests

3 participants