Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Field Compiler R1CS Synthesis #950

Closed
7 tasks done
gluax opened this issue May 11, 2021 · 0 comments · Fixed by #957
Closed
7 tasks done

[Feature] Field Compiler R1CS Synthesis #950

gluax opened this issue May 11, 2021 · 0 comments · Fixed by #957
Assignees
Labels
feature A new feature.

Comments

@gluax
Copy link
Contributor

gluax commented May 11, 2021

🚀 Feature

We should support the operators ==.!= on the field type.
This depends on snarkVM first implementing these features.

Motivation

Fields should have equality operations, as this also blocks #946 and blocks #947.
Which helps the implementation goal of #929.

Implementation

Field Gadget

  • Implement the impl<F: PrimeField> EvaluateEqGadget<F> for Field trait leo/compiler/src/value/field/field_type.rs.
  • Implement the impl<F: PrimeField> ComparatorGadget<F> for Field trait leo/compiler/src/value/field/field_type.rs.
  • Implement the impl<F: PrimeField> EqGadget<F> for Field trait leo/compiler/src/value/field/field_type.rs.
  • Implement the impl<F: PrimeField> ConditionalEqGadget<F> for Field trait leo/compiler/src/value/field/field_type.rs.

Tests

  • Compiler Tests:
    • Test == for the field type.
    • Test != for the field type.
@gluax gluax added the feature A new feature. label May 11, 2021
This was referenced May 11, 2021
@gluax gluax mentioned this issue May 11, 2021
29 tasks
@gluax gluax self-assigned this May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant