Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings RFC updates #928

Merged
merged 7 commits into from
May 7, 2021
Merged

Strings RFC updates #928

merged 7 commits into from
May 7, 2021

Conversation

acoglio
Copy link
Collaborator

@acoglio acoglio commented May 7, 2021

For tomorrow's meeting.

@acoglio acoglio requested review from bendyarm, damirka and gluax May 7, 2021 04:11
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #928 (554cc30) into master (2ddb474) will decrease coverage by 0.18%.
The diff coverage is n/a.

❗ Current head 554cc30 differs from pull request most recent head 50e6f93. Consider uploading reports for the commit 50e6f93 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #928      +/-   ##
==========================================
- Coverage   77.46%   77.27%   -0.19%     
==========================================
  Files         467      467              
  Lines       20266    20266              
==========================================
- Hits        15699    15661      -38     
- Misses       4567     4605      +38     
Impacted Files Coverage Δ
compiler/src/expression/arithmetic/pow.rs 0.00% <0.00%> (-55.56%) ⬇️
compiler/tests/integers/int_macro.rs 92.15% <0.00%> (-7.85%) ⬇️
compiler/src/value/integer/integer.rs 81.94% <0.00%> (-4.87%) ⬇️
compiler/src/value/integer/macros.rs 57.69% <0.00%> (-3.85%) ⬇️
compiler/src/expression/expression.rs 92.68% <0.00%> (-1.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3efe3ea...50e6f93. Read the comment docs.

(b2) (1 - b2) = 0
...
```
that take the different, double it, and convert to bits.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

different --> difference

Copy link
Collaborator

@bendyarm bendyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve but mention typo line 304

Also auto-remove trailing whitespace.
@acoglio acoglio merged commit 5ee18b4 into master May 7, 2021
@acoglio acoglio deleted the rfc-strings-updates branch May 7, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants