-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strings RFC updates #928
Strings RFC updates #928
Conversation
Fix a few typos, improve some text, streamline some text.
This is based on a Slack conversation with Pratyush.
Codecov Report
@@ Coverage Diff @@
## master #928 +/- ##
==========================================
- Coverage 77.46% 77.27% -0.19%
==========================================
Files 467 467
Lines 20266 20266
==========================================
- Hits 15699 15661 -38
- Misses 4567 4605 +38
Continue to review full report at Codecov.
|
docs/rfc/001-initial-strings.md
Outdated
(b2) (1 - b2) = 0 | ||
... | ||
``` | ||
that take the different, double it, and convert to bits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
different --> difference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve but mention typo line 304
Also auto-remove trailing whitespace.
For tomorrow's meeting.