Revert "Merge pull request AleoNet#3254 from niklaslong/fix/cache"

This reverts commit 7ff06a8, reversing
changes made to 9cc67c9.

node/bft/src/gateway.rs

@@ -1085,11 +1085,6 @@ impl<N: Network> Disconnect for Gateway<N> {
     async fn handle_disconnect(&self, peer_addr: SocketAddr) {
         if let Some(peer_ip) = self.resolver.get_listener(peer_addr) {
             self.remove_connected_peer(peer_ip);
-
-            // We don't clear this map based on time but only on peer disconnect.
-            // This is sufficient to avoid infinite growth as the committee has a fixed number
-            // of members.
-            self.cache.clear_outbound_validators_requests(peer_ip);
         }
     }
 }

node/bft/src/helpers/cache.rs

@@ -119,11 +119,6 @@ impl<N: Network> Cache<N> {
     pub fn decrement_outbound_validators_requests(&self, peer_ip: SocketAddr) -> u32 {
         Self::decrement_counter(&self.seen_outbound_validators_requests, peer_ip)
     }
-
-    /// Clears the the IP's number of validator requests.
-    pub fn clear_outbound_validators_requests(&self, peer_ip: SocketAddr) {
-        self.seen_outbound_validators_requests.write().remove(&peer_ip);
-    }
 }
 
 impl<N: Network> Cache<N> {
@@ -298,27 +293,4 @@ mod tests {
        outbound_certificate,
        outbound_transmission
     }
-
-    #[test]
-    fn test_seen_outbound_validators_requests() {
-        let cache = Cache::<CurrentNetwork>::default();
-        let input = Input::input();
-
-        // Check the map is empty.
-        assert!(!cache.contains_outbound_validators_request(input));
-
-        // Insert some requests.
-        for _ in 0..3 {
-            cache.increment_outbound_validators_requests(input);
-            assert!(cache.contains_outbound_validators_request(input));
-        }
-
-        // Remove a request.
-        cache.decrement_outbound_validators_requests(input);
-        assert!(cache.contains_outbound_validators_request(input));
-
-        // Clear all requests.
-        cache.clear_outbound_validators_requests(input);
-        assert!(!cache.contains_outbound_validators_request(input));
-    }
 }