Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 16: MarshalBinary Favorites #28

Merged

Conversation

ifanchu
Copy link
Contributor

@ifanchu ifanchu commented Dec 29, 2020

Implement encoding.BinaryMarshaler for all Favorites structs.

fav.go Outdated Show resolved Hide resolved
Copy link
Member

@PichuChen PichuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只有一處需要修改,panic部分希望以error方式回傳

Implement encoding.BinaryMarshaler for all Favorites structs.
@ifanchu ifanchu force-pushed the topic/ifanchu/issue16-fav-write branch from a640a27 to ef58d9f Compare December 30, 2020 09:48
@PichuChen PichuChen merged commit aaeead5 into Ptt-official-app:master Dec 30, 2020
@PichuChen
Copy link
Member

新增ref 到 #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants