Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

fix empty network_interface_groups in the module info #46

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

genalt
Copy link
Contributor

@genalt genalt commented Jan 18, 2023

SUMMARY

In the module info we can gather Fusion information using network_interface_groups. It should returns the same information as nigs, but instead it returns nothing. See code here

if "nigs" in subset or "all" in subset:

I fixed the problem and added information for network_interface_groups.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

Module fusion_info.

ADDITIONAL INFORMATION
  • changelog
bugfixes:
  - fusion_info - network_interface_groups subset returned nothing. Now it collects the same information
    as nigs subset (https://github.com/Pure-Storage-Ansible/Fusion-Collection/pull/46).
deprecated_features:
  - fusion_info - nigs subset is deprecated in favor of network_interface_groups and will be removed
    in the version 1.7.0 (https://github.com/Pure-Storage-Ansible/Fusion-Collection/pull/46).

@genalt genalt requested a review from sdodsley January 18, 2023 14:04
@CLAassistant
Copy link

CLAassistant commented Jan 18, 2023

CLA assistant check
All committers have signed the CLA.

@sdodsley
Copy link
Member

You can't really deprecate a parametr in Ansible without a lot of warning. Use alias instead.

Copy link
Member

@sdodsley sdodsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use alias

@sdodsley sdodsley self-requested a review January 26, 2023 14:16
Copy link
Member

@sdodsley sdodsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a release note in changelog/fragments. Name the file <PR#>_<short description>.yaml
See https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment

@genalt
Copy link
Contributor Author

genalt commented Jan 30, 2023

You can't really deprecate a parametr in Ansible without a lot of warning. Use alias instead.

Thank you for the review @sdodsley. I am not deprecating any argument (parameter). It is still gather_subset

argument_spec.update(
        dict(gather_subset=dict(default="minimum", type="list", elements="str"))
    )

We use aliases to give another name to the argument, so this is not the case here.

My initial intension was to not allow to use value nigs and use network_interface_groups instead.

I am OK, to keep both of them just to no introduce backward incompatible changes.

@genalt genalt force-pushed the HM-4977-remove-nigs-subset branch from c2b2686 to 78cab20 Compare January 30, 2023 12:30
@genalt genalt requested a review from sdodsley January 30, 2023 12:31
@genalt genalt force-pushed the HM-4977-remove-nigs-subset branch 2 times, most recently from 76e84a5 to a2e98cf Compare January 30, 2023 14:18
@genalt genalt requested a review from sdodsley January 30, 2023 14:19
Copy link
Member

@sdodsley sdodsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a releaee note for this as well in changelog/fragments. There is a naming convention for this files... <PR#>_<short description>.yaml

@genalt genalt force-pushed the HM-4977-remove-nigs-subset branch from a2e98cf to 3977c92 Compare January 30, 2023 14:43
@genalt
Copy link
Contributor Author

genalt commented Jan 30, 2023

Please create a releaee note for this as well in changelog/fragments. There is a naming convention for this files... <PR#>_<short description>.yaml

Added changelogs/fragments/PR46_network_interface_groups.yaml with information

@genalt genalt force-pushed the HM-4977-remove-nigs-subset branch 2 times, most recently from be6206b to aaadb1c Compare January 30, 2023 14:54
@genalt genalt force-pushed the HM-4977-remove-nigs-subset branch 2 times, most recently from 3800893 to 038feda Compare January 30, 2023 16:38
@genalt genalt requested a review from sdodsley January 30, 2023 16:39
@genalt genalt force-pushed the HM-4977-remove-nigs-subset branch 3 times, most recently from a64d099 to 6b3e04d Compare January 30, 2023 16:45
@genalt genalt force-pushed the HM-4977-remove-nigs-subset branch from 6b3e04d to cace009 Compare January 30, 2023 16:45
@sdodsley sdodsley merged commit ef61b86 into master Jan 30, 2023
@genalt genalt deleted the HM-4977-remove-nigs-subset branch January 30, 2023 18:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants