-
Notifications
You must be signed in to change notification settings - Fork 11
fix empty network_interface_groups in the module info #46
Conversation
You can't really deprecate a parametr in Ansible without a lot of warning. Use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use alias
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a release note in changelog/fragments
. Name the file <PR#>_<short description>.yaml
See https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment
Thank you for the review @sdodsley. I am not deprecating any argument (parameter). It is still argument_spec.update(
dict(gather_subset=dict(default="minimum", type="list", elements="str"))
) We use aliases to give another name to the argument, so this is not the case here. My initial intension was to not allow to use value I am OK, to keep both of them just to no introduce backward incompatible changes. |
c2b2686
to
78cab20
Compare
76e84a5
to
a2e98cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a releaee note for this as well in changelog/fragments
. There is a naming convention for this files... <PR#>_<short description>.yaml
a2e98cf
to
3977c92
Compare
Added |
be6206b
to
aaadb1c
Compare
3800893
to
038feda
Compare
a64d099
to
6b3e04d
Compare
6b3e04d
to
cace009
Compare
SUMMARY
In the module
info
we can gather Fusion information usingnetwork_interface_groups
. It should returns the same information asnigs
, but instead it returns nothing. See code hereFusion-Collection/plugins/modules/fusion_info.py
Line 910 in cdd8c2e
I fixed the problem and added information for
network_interface_groups
.ISSUE TYPE
COMPONENT NAME
Module
fusion_info
.ADDITIONAL INFORMATION