fix: the addEventListener was not adding correctly

Purii · Sep 29, 2022 · a11cd08 · a11cd08
1 parent 51650ed
commit a11cd08
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -11,7 +11,7 @@ export interface useScrollSpyParams {
 export default ({
   activeSectionDefault = 0,
   offsetPx = 0,
-  scrollingElement = window,
+  scrollingElement = null,
   sectionElementRefs = [],
   throttleMs = 100,
 }: useScrollSpyParams ) => {
@@ -37,13 +37,17 @@ export default ({
   });
 
   useEffect(() => {
-    scrollingElement.addEventListener('scroll', handle);
+    let scrollable = scrollingElement == null
+      ? window
+      : scrollingElement.current
+
+      scrollable.addEventListener('scroll', handle);
 
     // Run initially
     handle();
 
     return () => {
-      scrollingElement.removeEventListener('scroll', handle);
+      scrollable.removeEventListener('scroll', handle);
     };
   }, [sectionElementRefs, offsetPx]);
   return activeSection;