Añadir listado de charlas propuestas (Issue #243) #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Se agrega botón en la barra de navegación "My Talks" para los usuarios logueados. Este redirecciona a una página con el listado de charlas relacionadas a un usuario logueado.
pyjavo
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Tiene buena pinta. Por favor corrige el error del Pylint (entre clase y clase deben haber 2 espacios en blanco).
Alguna duda, luego de enviado tu commit, puedes verificar al final de tu pull request, en la sección dónde están los checks.
La otra opción es instalar pre-commit localmente y correr este comando a ver si todo pasa bien
pre-commit run --show-diff-on-failure --color=always --all-files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Se agrega botón en la barra de navegación "My Talks" para los usuarios logueados. Este redirecciona a una página con el listado de charlas relacionadas a un usuario logueado.
Pull request
Closes #243
Barra de navegación de un usuario no logueado:
Barra de navegación de un usuario logueado:
Sección con el listado de charlas relacionadas con un usuario logueado: