-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change package name or not #232
Comments
I prefer option a, and option a2 with a release to tell people to use 'mysqldb'. This would help anyone stuck installing the old mysqldb, and reduce confusion between the two names. |
I prefer a1. This could save users some troubles. Release packages for both name won't be a burden once the CI gets setup. As mysqlclient was once a drop-in replacement, it won't break anyone's code either. Users can continue to use the package name and imports they currently use, all they need to do is bumping version. It would feel like "it just work" to all users. |
A1 introduce troubles. If both of mysqlclient and MySQLdb are "proper" "maintained" "recommended" package, which should be used? To avoid such confusion, we need one recommended name. Additionally, I don't want to release same package to both name. |
The scenario you described will always happen, as those two names are already widely used. It can't be solved by any above means. Unless one name got entirely removed from PyPI, so everyone affected would be forced to switch to the "recommended" name, because they can't install through old name anymore, but this is definitely disastrous and won't worth the trouble.
So my prefs: |
It can be solved. MySQLdb become minor and minor. There are very few people installs MySQLdb newly by If Additionally, I don't want increase maintenance cost.
No. MySQLdb and mysqlclient conflicts. It can breaks their environment, if
I agree that this option requires some efforts to all users. I think this option should be considered. But I don't have motivation for this project to inform widely this transition. |
After re-reading PEP 541, I think a is impossible.
So I must not be able to take over MySQL-python. |
IMO, changing
@methane If that's the case, I'm perfectly OK with I guess something could be learned from pillow, like explicitly advertising as |
I just meant changing import path is not "unacceptable" or "should not be considered" option. |
hey there, just a check in from downstream land, all the things i complained about in #44 have not happened, @farcepest is as far as I can tell 100% not reachable for many years now and I think all my users use mysqlclient now. if the pypi overlords want to give you mysql-python, that would be fine too. |
I decided to not change (b1). |
PEP 541 is accepted.
But I think most users already switched from MySQLdb to mysqlclient.
So, what should we do for now?
a. Claim taking over MySQLdb on PyPIa1. Release package for both namea2. Remove mysqlclient and continue MySQLdbNow I prefer b1.
a is removed, see #232 (comment)
The text was updated successfully, but these errors were encountered: