-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to customize ssl mode settings #474
Comments
thereisnosun
pushed a commit
to thereisnosun/mysqlclient
that referenced
this issue
Jan 13, 2021
… handling for MariaDB lib)
I already provided the PR, which is fixing the issue described above: |
thereisnosun
pushed a commit
to thereisnosun/mysqlclient
that referenced
this issue
Feb 25, 2021
…ion and case sensitivity)
The documentation in https://mysqlclient.readthedocs.io/ is outdated and hence missing this information (#552) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment mysql-client have following defined:
meaning, that it will accept
ssl_mode
argument only in the case of MySQL, but not in the case of MariaDB. This is pretty odd, because even though MariaDB does not support the sophisticatedssl_mode
argument as MySQL does, it still allows some SSL tweaking:MYSQL_OPT_SSL_VERIFY_SERVER_CERT: Enables (or disables) server certificate verification
MYSQL_OPT_SSL_ENFORCE: Whether to force TLS. This enables TLS with the default system settings. It does not prevent the connection from being created if the server does not support TLS.
See more: https://mariadb.com/kb/en/mysql_optionsv/
So, seems logical for me to do is to allow the same ssl_mode option for MariaDB, but inside of mysqlclient handle it accordingly. So for the lib user, the interface would remain the same.
The text was updated successfully, but these errors were encountered: