Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bytes encoder that was specifically for Django 1.11 #490

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

rsiemens
Copy link
Contributor

Fixes #489

Seems this may have just been missed in #411

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #490 (084c6da) into master (24aaa72) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
- Coverage   84.32%   84.29%   -0.03%     
==========================================
  Files           6        6              
  Lines         555      554       -1     
==========================================
- Hits          468      467       -1     
  Misses         87       87              
Impacted Files Coverage Δ
MySQLdb/connections.py 81.11% <ø> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24aaa72...084c6da. Read the comment docs.

@methane
Copy link
Member

methane commented Mar 27, 2021

As I listed it in #472, I will remove it in v2.1.

But no schedule for v2.1 yet. Current master branch is for maintain v2.0. So I can not merge this PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection.escape fails to escape byte strings and raises TypeError: bytes() argument 2 must be str, not dict.
2 participants