Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ssl=True #700

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Support ssl=True #700

merged 2 commits into from
Feb 8, 2024

Commits on Feb 8, 2024

  1. Support ssl=True 

    MySQL use ssl by default but MariaDB don't.

Until mysqlclient<=2.2.1, `ssl=True` unintentionally allowed and
it called `mysql_ssl_set(mysql, NULL, NULL, NULL, NULL, NULL)`.
Although it is no-op in MySQL Connector, MariaDB Connector silently
set MYSQL_OPT_SSL_ENFORCE when the API is called. (See PyMySQL#698)

In case of PyMySQL, ssl is not used by default but `ssl=True` behave like
`sslmode="PREFERRED"`.

For better backward compatibility and compatibility with PyMySQL and
security, I decided to allow ssl=True and it means sslmode="REQUIRED".
    @methane
    methane committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    d79eabf View commit details
    Browse the repository at this point in the history

  2. fix warning

    @methane
    methane committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    93fbaf9 View commit details
    Browse the repository at this point in the history