Declarative modules: make sure to emit doc comments and other attribu…

…tes (#4236) * Declarative modules: make sure to emmit doc comments and other attributes * Adds a test * Apply suggestions from code review --------- Co-authored-by: David Hewitt <mail@davidhewitt.dev>
PyO3 · Jun 6, 2024 · 7461914 · 7461914
1 parent c644c0b
commit 7461914
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/newsfragments/4236.fixed.md b/newsfragments/4236.fixed.md
@@ -0,0 +1 @@
+Declarative modules: do not discard doc comments on the `mod` node.
diff --git a/pyo3-macros-backend/src/module.rs b/pyo3-macros-backend/src/module.rs
@@ -287,6 +287,7 @@ pub fn pymodule_module_impl(mut module: syn::ItemMod) -> Result<TokenStream> {
 
     let initialization = module_initialization(&name, ctx);
     Ok(quote!(
+        #(#attrs)*
         #vis mod #ident {
             #(#items)*
 

diff --git a/tests/ui/pymodule_missing_docs.rs b/tests/ui/pymodule_missing_docs.rs
@@ -9,4 +9,9 @@ pub fn python_module(_m: &Bound<'_, PyModule>) -> PyResult<()> {
     Ok(())
 }
 
+#[cfg(feature = "experimental-declarative-modules")]
+/// Some module documentation
+#[pymodule]
+pub mod declarative_python_module {}
+
 fn main() {}